1226742 - Port bug 1208295 - display notification permissions from the notification settings menu

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, defect)

Description

[[e-mail]]

Web notifications now support an additional menu with items to block notifications and open notification settings. The notification blocking ties into the existing permission management but the settings generates a notifications-open-settings observer notification which needs to be handled by the suite glue somehow.

Comment 1

[[e-mail]]

Attachment: Possible patch

Comment 2

[Philip Chee]

Comment on attachment 8690542 [details] [diff] [review]
Possible patch

As far as I can tell this patch *should* work. But I'm not getting anything when I click on the "Notification settings" button. I put a console.log and |case "notifications-open-settings":| isn't even called. Is there a pref I should flip?

I'll do another build tonight to see if anything changes.

Comment 3

[Philip Chee]

Comment on attachment 8690542 [details] [diff] [review]
Possible patch

For some reason I had notification.feature.enabled set to true. Setting it to false allows this patch to work.

Comment 4

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/d9e97a5db579

Comment 5

[Philip Chee]

Comment on attachment 8690542 [details] [diff] [review]
Possible patch

[Triage Comment]

Backport to SeaMonkey 2.41

[Approval Request Comment]
Regression caused by (bug #): Not a regression. Part of bug 1208295
(Open content preferences after receiving notifications-open-settings)
User impact if declined: Does not open the data manager/permissions tab when the settings button in the OSX alert notification is clicked.
Testing completed (on m-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): low to none risk.
String changes made by this patch: None.

Comment 6

[Philip Chee]

Pushed to SeaMonkey 2.41 (comm-beta)
https://hg.mozilla.org/releases/comm-beta/rev/6e294a71e964