1226878 - Percentages/values all wrong when filtering

Status: RESOLVED FIXED

(DevTools :: Memory, defect, P1)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 696237.fxsnapshot

STR:
* Open up attached snapshot
* Set breakdowns to Allocation Site
* Type in "memory" into the filter

ER: Not get values like 1336%
AR: Get values like 1336%

This snapshot was from an unscoped browser toolbox.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: Screen Shot 2015-11-21 at 8.54.30 AM.png

Screenshot -- note, tree must be uninverted.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Correctness of reporting our measurements is very high priority.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Additional STR from bug 1241592:

> Steps to reproduce:
> 
> 1. Start Nightly
> 2. Open Memory Tool
> 3. Run "Take Snapshot"
> 4. Set filter word (e.g. "objects")
> 
> Actual results:
> 
> heap-tree-percent is over 100%.
> 
> Expected results:
> 
> It should not be overflowed. If calculation is wrong, should work correctly.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Fix incorrect totals and percents in memory tool

When filtering, we were merging total counts and total bytes as we added
matching paths from the unfiltered tree into the new, filtered tree. This was
incorrect, and caused us to double, triple, ... count the totals.

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fe6b2cd6076

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/24ff441e96b5

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/24ff441e96b5