1227230 - Remove all of the e10s prompting code

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[:Felipe Gomes (needinfo for replies!)]

We have a lot of code to display e10s-related prompts that we won't use anymore and can be removed:

- Doorhanger inviting users to opt-in to e10s
  -- we have e10s-by-default in nightly/aurora and do not want to prompt users on beta

- message requesting feedback on input.mozilla.org when e10s is disabled in the preferences dialog
  -- it's unclear whether anyone has looked at that feedback recently

- infobar saying "You're helping to test multi-process" when e10s is first enabled
  -- most users on nightly/aurora have already been exposed to e10s


Only the last item would be somewhat useful to keep, but removing it together with the other ones mean a good chunk of code can go away. I'm happy to re-add the code if we need it again in the future   (the only downside is that it has one localized string that would need to be re-added. or we could keep the string but remove all the rest of the code)

Comment 1

[Jim Mathies [:jimm]]

I think it's time we get rid of all this stuff, especially the feedback tab on restart when you change the e10s pref.

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: MozReview Request: Bug 1227230 - Remove all of the e10s prompting code. r=jimm

This removes all of the e10s-related prompting code, including:
- doorhanger offering to opt-in into e10s
- pref and telemetry probe used to measure the number of users who remained opted-in
- dialog that shows up when unchecking the e10s checkbox saying that a tab will open, requesting feedback
- tab opening requesting feedback
- all related strings

The checkbox in the preferences window remains (nightly/aurora only), as well as the message saying that e10s requires a restart.

The e10s accessibility doorhanger remains. and chrome://browser/skin/[e-mail] remains too because it's also used in the a11y doorhanger.

Review commit: https://reviewboard.mozilla.org/r/52351/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52351/

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8751985 [details]
MozReview Request: Bug 1227230 - Remove all of the e10s prompting code. r=jimm

https://reviewboard.mozilla.org/r/52351/#review49437

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/017ec43202c9

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/017ec43202c9