Closed Bug 1227515 Opened 4 years ago Closed 4 years ago

e10s testing notification triggers in browser chrome test runs, causing failures

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
e10s + ---
firefox45 --- fixed

People

(Reporter: jimm, Assigned: jimm)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

Found while debugging bug 1221081. Apparently our e10s notification is showing up while tests run.

https://treeherder.mozilla.org/logviewer.html#?job_id=14029984&repo=try

 15:35:55     INFO -  114 INFO * label:You're now helping to test multi-process in Firefox Developer Edition! Please report problems you find.
 15:35:55     INFO -  115 INFO * type:warning
 15:35:55     INFO -  116 INFO * value:e10s-activated-noticed
Assignee: nobody → felipc
Blocks: e10s-tests
Looks like we need to prime browser.displayedE10SNotice as well based on the code here - 

https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-unknown-linux-gnu/dist/bin/browser/components/nsBrowserGlue.js#3069
Bug 1227515 - Avoid displaying the e10s offer notification when running browser chrome tests. r?felipe
Attachment #8694838 - Flags: review?(felipc)
Comment on attachment 8694838 [details]
MozReview Request: Bug 1227515 - Avoid displaying the e10s offer notification when running browser chrome tests. r?felipe

https://reviewboard.mozilla.org/r/26901/#review24373
Attachment #8694838 - Flags: review?(felipc) → review+
Keywords: checkin-needed
Assignee: felipc → jmathies
https://hg.mozilla.org/mozilla-central/rev/5b0340805108
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Attachment #8694838 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.