1227515 - e10s testing notification triggers in browser chrome test runs, causing failures

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jim Mathies [:jimm]]

Found while debugging bug 1221081. Apparently our e10s notification is showing up while tests run.

https://treeherder.mozilla.org/logviewer.html#?job_id=14029984&repo=try

 15:35:55     INFO -  114 INFO * label:You're now helping to test multi-process in Firefox Developer Edition! Please report problems you find.
 15:35:55     INFO -  115 INFO * type:warning
 15:35:55     INFO -  116 INFO * value:e10s-activated-noticed

Comment 1

[Jim Mathies [:jimm]]

Looks like we need to prime browser.displayedE10SNotice as well based on the code here - 

https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-unknown-linux-gnu/dist/bin/browser/components/nsBrowserGlue.js#3069

Comment 2

[Jim Mathies [:jimm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5eb3efc837b0

Comment 3

[Jim Mathies [:jimm]]

Attachment: MozReview Request: Bug 1227515 - Avoid displaying the e10s offer notification when running browser chrome tests. r?felipe

Bug 1227515 - Avoid displaying the e10s offer notification when running browser chrome tests. r?felipe

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8694838 [details]
MozReview Request: Bug 1227515 - Avoid displaying the e10s offer notification when running browser chrome tests. r?felipe

https://reviewboard.mozilla.org/r/26901/#review24373

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5b0340805108

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5b0340805108