Closed
Bug 1227322
Opened 9 years ago
Closed 9 years ago
Remove nightly flag from set homepage pref
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox44 verified, firefox45 verified, b2g-v2.5 fixed, relnote-firefox 44+, fennec44+)
RESOLVED
FIXED
Firefox 45
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(2 files)
40 bytes,
text/x-review-board-request
|
Margaret
:
review+
|
Details |
1.66 KB,
patch
|
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
And uplift to 44.
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1227322 - Remove nightly flag from homepage pref. r=margaret It seems like too much work to make a full branded non-nightly build so I didn't strictly test this but I looked around the homepage code and saw no other blockers on set homepage.
Attachment #8691076 -
Flags: review?(margaret.leibovic)
Comment 2•9 years ago
|
||
Comment on attachment 8691076 [details] MozReview Request: Bug 1227322 - Remove nightly flag from homepage pref. r=margaret https://reviewboard.mozilla.org/r/26063/#review23429 This looks good to me. See also the changeset where this was added: http://hg.mozilla.org/mozilla-central/rev/9f0c016e855b Unfortunately, there might be conflicts trying to applying this patch to Aurora, because of the settings reorg. But luckily this is a small patch, so should be easy to un-bitrot. Let's also make sure we uplift a fix for bug 1224214.
Attachment #8691076 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d7f5fc8192f5f4230e768f8c7ce0cf325e5c2cca Bug 1227322 - Remove nightly flag from homepage pref. r=margaret
Assignee | ||
Comment 4•9 years ago
|
||
Assignee | ||
Comment 5•9 years ago
|
||
Note: I didn't build or test the branch patch because it's probably not worth the time for such a simple change.
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8691111 [details] [diff] [review] 44 (aurora) branch patch Approval Request Comment [Feature/regressing bug #]: Feature: bug 1195721 [User impact if declined]: Users won't get this feature until v45 [Describe test coverage new/current, TreeHerder]: None [Risks and why]: Low, we're removing the Nightly flag. Worst case, compile error, runtime error when setting up prefs, or the preference isn't removed as expected. [String/UUID change made/needed]: None
Attachment #8691111 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d7f5fc8192f5
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Comment on attachment 8691111 [details] [diff] [review] 44 (aurora) branch patch I was told that this fix is also needed for 44. Let's uplift to Aurora.
Attachment #8691111 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox44:
--- → affected
Assignee | ||
Comment 9•9 years ago
|
||
Release Note Request (optional, but appreciated) [Why is this notable]: (see suggested wording) [Suggested wording]: Users can customize their homepage when starting Firefox [Links (documentation, blog post, etc)]: n/a
relnote-firefox:
--- → ?
Comment 10•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/b204be8f7416
Comment 11•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b204be8f7416
status-b2g-v2.5:
--- → fixed
Added to Beta44 release notes.
Comment 13•8 years ago
|
||
Verified as fixed on Aurora 45.0a2 (2015-12-17) and Firefox 44 Beta 1
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•