Remove nightly flag from set homepage pref

RESOLVED FIXED in Firefox 44, Firefox OS v2.5

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

unspecified
Firefox 45
All
Android
Points:
---

Firefox Tracking Flags

(firefox44 verified, firefox45 verified, b2g-v2.5 fixed, relnote-firefox 44+, fennec44+)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

And uplift to 44.
Created attachment 8691076 [details]
MozReview Request: Bug 1227322 - Remove nightly flag from homepage pref. r=margaret

Bug 1227322 - Remove nightly flag from homepage pref. r=margaret

It seems like too much work to make a full branded non-nightly build so I
didn't strictly test this but I looked around the homepage code and saw no
other blockers on set homepage.
Attachment #8691076 - Flags: review?(margaret.leibovic)

Comment 2

2 years ago
Comment on attachment 8691076 [details]
MozReview Request: Bug 1227322 - Remove nightly flag from homepage pref. r=margaret

https://reviewboard.mozilla.org/r/26063/#review23429

This looks good to me. See also the changeset where this was added:
http://hg.mozilla.org/mozilla-central/rev/9f0c016e855b

Unfortunately, there might be conflicts trying to applying this patch to Aurora, because of the settings reorg. But luckily this is a small patch, so should be easy to un-bitrot.

Let's also make sure we uplift a fix for bug 1224214.
Attachment #8691076 - Flags: review?(margaret.leibovic) → review+
Note: I didn't build or test the branch patch because it's probably not worth the time for such a simple change.
Comment on attachment 8691111 [details] [diff] [review]
44 (aurora) branch patch

Approval Request Comment
[Feature/regressing bug #]: Feature: bug 1195721
[User impact if declined]: Users won't get this feature until v45

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Low, we're removing the Nightly flag. Worst case, compile error, runtime error when setting up prefs, or the preference isn't removed as expected.

[String/UUID change made/needed]: None
Attachment #8691111 - Flags: approval-mozilla-aurora?

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d7f5fc8192f5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45

Comment 8

2 years ago
Comment on attachment 8691111 [details] [diff] [review]
44 (aurora) branch patch

I was told that this fix is also needed for 44. Let's uplift to Aurora.
Attachment #8691111 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

2 years ago
status-firefox44: --- → affected
Release Note Request (optional, but appreciated)
[Why is this notable]: (see suggested wording)
[Suggested wording]: Users can customize their homepage when starting Firefox
[Links (documentation, blog post, etc)]: n/a
relnote-firefox: --- → ?

Comment 10

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/b204be8f7416
status-firefox44: affected → fixed
Added to Beta44 release notes.
relnote-firefox: ? → 44+

Comment 13

2 years ago
Verified as fixed on Aurora 45.0a2 (2015-12-17) and Firefox 44 Beta 1
status-firefox44: fixed → verified
status-firefox45: fixed → verified
You need to log in before you can comment on or make changes to this bug.