1227322 - Remove nightly flag from set homepage pref

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

And uplift to 44.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1227322 - Remove nightly flag from homepage pref. r=margaret

Bug 1227322 - Remove nightly flag from homepage pref. r=margaret

It seems like too much work to make a full branded non-nightly build so I
didn't strictly test this but I looked around the homepage code and saw no
other blockers on set homepage.

Comment 2

[:Margaret Leibovic]

Comment on attachment 8691076 [details]
MozReview Request: Bug 1227322 - Remove nightly flag from homepage pref. r=margaret

https://reviewboard.mozilla.org/r/26063/#review23429

This looks good to me. See also the changeset where this was added:
http://hg.mozilla.org/mozilla-central/rev/9f0c016e855b

Unfortunately, there might be conflicts trying to applying this patch to Aurora, because of the settings reorg. But luckily this is a small patch, so should be easy to un-bitrot.

Let's also make sure we uplift a fix for bug 1224214.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/d7f5fc8192f5f4230e768f8c7ce0cf325e5c2cca
Bug 1227322 - Remove nightly flag from homepage pref. r=margaret

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: 44 (aurora) branch patch

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Note: I didn't build or test the branch patch because it's probably not worth the time for such a simple change.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8691111 [details] [diff] [review]
44 (aurora) branch patch

Approval Request Comment
[Feature/regressing bug #]: Feature: bug 1195721
[User impact if declined]: Users won't get this feature until v45

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Low, we're removing the Nightly flag. Worst case, compile error, runtime error when setting up prefs, or the preference isn't removed as expected.

[String/UUID change made/needed]: None

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d7f5fc8192f5

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8691111 [details] [diff] [review]
44 (aurora) branch patch

I was told that this fix is also needed for 44. Let's uplift to Aurora.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Release Note Request (optional, but appreciated)
[Why is this notable]: (see suggested wording)
[Suggested wording]: Users can customize their homepage when starting Firefox
[Links (documentation, blog post, etc)]: n/a

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b204be8f7416

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b204be8f7416

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added to Beta44 release notes.

Comment 13

[u421692]

Verified as fixed on Aurora 45.0a2 (2015-12-17) and Firefox 44 Beta 1