Closed
Bug 1227622
Opened 9 years ago
Closed 9 years ago
Allow filtering results in compare view by performance framework
Categories
(Tree Management :: Perfherder, defect)
Tree Management
Perfherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: wlach)
References
Details
(Whiteboard: perfherder-starter-bug)
User Story
Thank you for helping out with Treeherder! You can find us on IRC at irc://irc.mozilla.org/treeherder Here's some links to help get you started. Project page: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder https://wiki.mozilla.org/Auto-tools/Projects/Perfherder Interacting with us, repo locations and links to set up a development version of the software: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Contributing https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Source_and_Docs A-Team general reference, coding style guides: https://ateam-bootcamp.readthedocs.org
Attachments
(1 file)
I have been seeing the build times in the compare view recently. I think the ability to show all data in compare chooser is rad! For the case of showing a talos regression, the build times are not useful, nor do we collect >1 data point.
an example:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-inbound&originalRevision=e665ea64eb15&newProject=mozilla-inbound&newRevision=4d8cadcfe408
|
Assignee | |
Comment 1•9 years ago
|
||
I think the solution is the same as what I just proposed for bug 1230652: let the user filter results in the compare view by performance framework, defaulting to talos.
See Also: → 1230652
Summary: compare view is showing build times, that is not useful for talos regressions → Allow filtering results in compare view by performance framework
Whiteboard: perfherder-hackfest-mozlando
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: perfherder-hackfest-mozlando → perfherder-starter-bug
|
|
Assignee | |
Updated•9 years ago
|
User Story: (updated)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Took a bit more work than I might have though, but this seems to work pretty well!
Attachment #8698157 -
Flags: review?(jmaher)
|
Reporter | |
Comment 4•9 years ago
|
||
Comment on attachment 8698157 [details] [review]
PR
after a few questions on irc- I am happy with this patch.
Attachment #8698157 -
Flags: review?(jmaher) → review+
|
||
Comment 5•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/522e4fa130f4ee75d3cf130546e4368f08cad2f1
Bug 1227622 - Add performance framework API endpoint
Also add information about performance frameworks to the list of performance
signatures we return.
https://github.com/mozilla/treeherder/commit/b43440ba5cb03657b6aaaaedf3b10510100bf643
Bug 1227622 - Filter compare view results by framework id
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/8ec3927f5d1e063d5a42ad4d8220629a46df6b2c
Bug 1227622 - Avoid 301 redirect in the getFrameworkList() API request
[18/Dec/2015:14:05:34 -0800] "GET /api/performance/framework HTTP/1.1" 301
- "https://treeherder.mozilla.org/perf.html"
"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:44.0) Gecko/20100101 Firefox/44.0"
You need to log in
before you can comment on or make changes to this bug.
Description
•