1230652 - Test chooser should filter by "performance framework"

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

We currently show all the performance signatures per platform mashed together in the test chooser. We should let the user choose which framework they're interested in seeing results for: the default should be Talos, since that's what people most commonly want to see.

Modifications necessary:

1. Add a webapi to list the existing performance frameworks
2. Allowing filtering tests, platforms by test framework in the existing perfherder web apis: https://github.com/mozilla/treeherder/blob/master/treeherder/webapp/api/performance_data.py
3. Updating the test chooser to incorporate a performance framework chooser (code here: https://github.com/mozilla/treeherder/blob/master/ui/partials/perf/testdatachooser.html and here: https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/perf/graphs.js#L779)

For points (1) and (2), it would be best to fix bug 1230651 first, so we can add unit tests for the new functionality.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:wlach, is this something we could prioritize to do earlier since it will facilitate our talos-aws experiments?

Comment 2

[William Lachance (:wlach)]

For sure, I can bump this up in my queue.

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1230652 > mozilla:master

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8740619 [details] [review]
[treeherder] wlach:1230652 > mozilla:master

I took the liberty of fixing some related bugs in the test chooser that should make things much more usable in general. In particular, the test chooser should now only show a list of up-to-date and relevant platforms for each branch/framework combination.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8740619 [details] [review]
[treeherder] wlach:1230652 > mozilla:master

lots of great cleanup here!

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla/treeherder/commit/aeb89e329419dad1a6b061c6d8c746cefacdc14f

Comment 7

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4d4177bc359d2ba0df46d6ab1a66af964db3563f
Bug 1230652 - Fix interval filtering for performance platforms endpoint

https://github.com/mozilla/treeherder/commit/9644d27c28d7f616dc0ebda3703eb0b9e31ef9a9
Bug 1230652 - Simplify front-end performance framework model

https://github.com/mozilla/treeherder/commit/87699a1b0b88c6972e84020799f14beb8bf8e57d
Bug 1230652 - Filter test list by performance framework in UI

https://github.com/mozilla/treeherder/commit/85f1aec173a759ef7dd1ca494a24256106b27a97
Bug 1230652 - Add framework filtering for platform list and use it

Comment 8

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1230652-2 > mozilla:master

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/1184cd7c7359b062e10ca65fa640b138d50c9834
Bug 1230652 - Fix default selection of framework in chooser

https://github.com/mozilla/treeherder/commit/94cb73d180a069f2c0e885fb0ca6637d2a5d9e3c
Merge pull request #1406 from wlach/1230652-2

Bug 1230652 - Fix default selection of framework in chooser

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

can we close this bug?