1227630 - Crashed background tabs lose their favicons

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1) Load several tabs with favicons
2) Crash the content process[1] while watching the background tabs with favicons

ER:

The background tabs should keep their favicons

AR:

The background tabs lose their favicons until reselected.

This is fallout from bug 1209689.

[1]: Either https://addons.mozilla.org/en-US/firefox/addon/tab-crasher/ or http://people.mozilla.org/~tmielczarek/crashme/ should be able to do the job.

Comment 1

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Hi,

I have managed to reproduce this issue on Windows 10, Windows 7, Ubuntu 14.04 and Mac OS X 10.7 on the latest Aurora release (46.0a2) and latest Nightly (47.0a1).

Build ID    20160207004019
User Agent  Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0
User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0
User Agent  Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0
User Agent  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:46.0) Gecko/20100101 Firefox/46.0

Thanks,
Cipri

Comment 3

[Jim Mathies [:jimm]]

hey Mike, any idea what the level of effort is here?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

(In reply to Jim Mathies [:jimm] from comment #3)
> hey Mike, any idea what the level of effort is here?

I think this will be fixed by bug 1096013, since we're essentially putting each background tab into the restored but unloaded state. The effort for bug 1096013 is not 100% clear to me, since I haven't dug into it too much. I figure it's probably not too bad though.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Jeff, what do you want to do here?

Comment 6

[Jeff Griffiths (:canuckistani) (:⚡︎)]

This feels like polish, but I think should be P1 as we will likely expose users to crashes.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

This was fixed as a consequence of bug 1096013 being fixed.

Comment 9

[Julien Cristau [:jcristau]]

I'm guessing we're probably not going to uplift bug 1096013 to beta.

Comment 10

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce the issue mentioned in comment 0 on Firefox 45.0a1 (BuildId:20151124030553).

This issue is verified flexed on Firefox 55.0b3 (BuildId:20170619071723) using Windows 10 64bit, Ubuntu 16.04 64bit and macOS 10.11.6.