Closed Bug 1227790 Opened 4 years ago Closed 4 years ago

[EME] Update MediaKeyStatus WebIDL enum to include "released", "output-restricted" and "status-pending"

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The specification for the MediaKeyStatus enumeration has changed. We should update to the current spec.

We will also need to change enumeration that we use to represent these in the GMP API. We need to be careful, because if a new Adobe GMP that uses the new larger GMP API enumeration tries to send one of the new values in an IPC message to an old version of Firefox that expects the old enumerated valued, the IPDL serialization of the enum value will fail, killing the GMP process.

So we need to be sure to not push a new Adobe GMP that uses the new values out to old versions of Firefox which use the new enum values.
Update MediaKeyStatus enum to match draft EME spec.
Attachment #8691673 - Flags: review?(bzbarsky)
Add the new MediaKeyStatus enum types to the end of the corresponding enum in the GMP API, and fixup the GMP enum to DOM enum helper function.
Attachment #8691674 - Flags: review?(jwwang)
Summary: [EME] Update MediaKeyStatuses to include "released", "output-restricted" and "status-pending" → [EME] Update MediaKeyStatus WebIDL enum to include "released", "output-restricted" and "status-pending"
Attachment #8691674 - Flags: review?(jwwang) → review+
Comment on attachment 8691673 [details] [diff] [review]
Patch 1: Update MediaKeyStatuses to include "released", "output-restricted" and "status-pending".

So the "output-not-allowed" value is just gone, right?

r=me
Attachment #8691673 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky [:bz] from comment #3)
> So the "output-not-allowed" value is just gone, right?

Yup.
Consider uplifing.
Flags: needinfo?(cpearce)
https://hg.mozilla.org/mozilla-central/rev/c9162d1acbe4
https://hg.mozilla.org/mozilla-central/rev/5c0a41a39290
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Depends on: 1229508
Flags: needinfo?(cpearce)
You need to log in before you can comment on or make changes to this bug.