[EME] Rev GMP_API_DECRYPTOR and support current and prev rev

RESOLVED FIXED in Firefox 45

Status

()

Core
Audio/Video: Playback
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 1 bug)

unspecified
mozilla45
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
In bug 1227790 I updated the MediaKeyStatus enum, and the GMPKeyStatus enum. But if Adobe's GMP uses the new GMPKeyStatus enum values in an old version of Firefox which doesn't support them, Firefox will kill the GMP.

So we should rev GMP_API_DECRYPTOR, and support the current and previous version of it in Firefox. Then the GMP can know it's safe to use the new enum values, as we'll request the newer GMP_API_DECRYPTOR actor.
(Assignee)

Comment 1

2 years ago
Created attachment 8694521 [details]
MozReview Request: Bug 1229508 - Support current and previous GMP_API_DECRYPTORs. r?gerald

Bug 1229508 - Support current and previous GMP_API_DECRYPTORs. r?gerald

To allow GMPs time to update to new GMPDecryptor versions, we support the
latest GMPDecryptor version, and the previous.

In order to support a consistent interface to Gecko, we adapt the previous
GMPDecryptor version to the latest in the GMP child process.  So Gecko always
thinks it's talking to the latest version.

We also make gmp-fake deliberately support the previous GMPDecryptor version,
to ensure this code path remains tested.
Attachment #8694521 - Flags: review?(gsquelart)
Comment on attachment 8694521 [details]
MozReview Request: Bug 1229508 - Support current and previous GMP_API_DECRYPTORs. r?gerald

https://reviewboard.mozilla.org/r/26817/#review24227

All good, assuming that the GMPs will do the right thing with enum values between API versions (which Adobe should, as discussed on IRC).
Attachment #8694521 - Flags: review?(gsquelart) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/98052e9e211a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.