Closed
Bug 1229508
Opened 9 years ago
Closed 9 years ago
[EME] Rev GMP_API_DECRYPTOR and support current and prev rev
Categories
(Core :: Audio/Video: Playback, defect, P1)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In bug 1227790 I updated the MediaKeyStatus enum, and the GMPKeyStatus enum. But if Adobe's GMP uses the new GMPKeyStatus enum values in an old version of Firefox which doesn't support them, Firefox will kill the GMP. So we should rev GMP_API_DECRYPTOR, and support the current and previous version of it in Firefox. Then the GMP can know it's safe to use the new enum values, as we'll request the newer GMP_API_DECRYPTOR actor.
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1229508 - Support current and previous GMP_API_DECRYPTORs. r?gerald To allow GMPs time to update to new GMPDecryptor versions, we support the latest GMPDecryptor version, and the previous. In order to support a consistent interface to Gecko, we adapt the previous GMPDecryptor version to the latest in the GMP child process. So Gecko always thinks it's talking to the latest version. We also make gmp-fake deliberately support the previous GMPDecryptor version, to ensure this code path remains tested.
Attachment #8694521 -
Flags: review?(gsquelart)
Comment on attachment 8694521 [details] MozReview Request: Bug 1229508 - Support current and previous GMP_API_DECRYPTORs. r?gerald https://reviewboard.mozilla.org/r/26817/#review24227 All good, assuming that the GMPs will do the right thing with enum values between API versions (which Adobe should, as discussed on IRC).
Attachment #8694521 -
Flags: review?(gsquelart) → review+
Comment 4•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/98052e9e211a
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•