1228037 - GeckoPreferences.PREFS_ZOOMED_VIEW_ENABLED is unused

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

To fix this bug, remove the declaration & definition of GeckoPreferences.PREFS_ZOOMED_VIEW_ENABLED [1].

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

[1]: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/preferences/GeckoPreferences.java?rev=6a3a062f53cb#121

Comment 1

[Samuel Mendes]

I'd like to take this one as my first bug. However, I need to set up a build environment first.

Should I wait until I set it?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Hey Samuel – welcome to Bugzilla! :) For first bugs, we wait until there's a patch submitted before assigning the bug. As such you'll need to set up your build environment, create a patch, and submit it. If you need help at all during this process, feel free to ask questions in this bug or on irc.

Comment 3

[Samuel Mendes]

Hi Michael, thank you for your reply. 

I'll try to set up my environment asap to come back here.

Comment 4

[Samuel Mendes]

Attachment: Removing the declaration and reference of GeckoPreferences.PREFS_ZOOMED_VIEW_ENABLED

Comment 5

[Samuel Mendes]

Attachment: bug_1228037_remove_geckoPreferences.patch

Comment 6

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Comment on attachment 8696258 [details] [diff] [review]
bug_1228037_remove_geckoPreferences.patch

Review of attachment 8696258 [details] [diff] [review]:
-----------------------------------------------------------------

Hey Samuel. The patch looks good to me but it doesn't apply on the latest fx-team so I can't push it to our try test servers. Do you mind rebasing your patch? Our source files have moved so that's likely the issue. You can find them at mobile/android/base/java/...

Comment 7

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Once the patch is rebased, we can send it to our test servers and once the push goes green, we can land it.

Also, I apologize for the delay – the team is at a conference this week so I've been intermittently available. I'll do my best to get to future patches more quickly.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Please use the "Need more information from" field when you post the rebased patch so I know to look at it.

Comment 9

[Samuel Mendes]

Attachment: bug_1228037_remove_geckoPreferences.patch

Comment 10

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5897b8781c22

Comment 11

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

I made a push to our try test servers (above).

Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 12

[Samuel Mendes]

There was a Robocop failed test but after while, it passed. 

Seems to me that everything went ok, right?

Comment 13

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Our test suites often get intermittent failures and this looks like one of them. Our harness will automatically rerun failures (as you can see from the green push). Additionally, if you click a failing test suite, you can look at the bar on the bottom of the screen and see if it matches any existing known intermittent failures, which are also listed on that bar (your failure does match).

This looks good to me and is ready for check-in!

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ea9df316f1cc

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea9df316f1cc

Comment 16

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Hey Samuel! If you'd like to keep helping out, may I suggest bug 1166833 or bug 1091826?