1166833 - Change layout spacing in settings

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

Copy the Android 5 spacing on the settings panel, then let's review and amend as necessary.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: spec_settinglist1.png

agreed, this is what I have now FWIW

Comment 2

[Samuel Mendes]

Hey guys, Happy Christmas!

I'd like to take this one buuuuuut I'm worse than Chewbacca doing design.

Does anybody who have a powerful force of will want to teach me the first steps?
Where should I start it?

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

IT'S A TRAP!

Sorry, Samuel, but the force was not with me when I chose this bug – I did some research and found that the layouts in our preference system is set up largely by the Android system (preferences.xml is a list of prefs that gets inflated into a view hierarchy) and there isn't much opportunity to customize the layouts without creating entirely custom layouts [1] which isn't worth it from a maintenance perspective. Extending the AppCompat preference libraries may fix this (bug 1205124) but that's a can of worms and I'd rather be a scruffy looking nerf herder than get it working properly.

However, bug 1227321 is similar and appears to be fixable – we write a custom preference, PanelsPreferenceCategory [2][3], that adds its own layouts which don't have the appropriate padding.

Would you like to have a look at that instead?

[1]: http://stackoverflow.com/a/11357268
[2]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/PanelsPreferenceCategory.java
[3]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/xml/preferences_home.xml?rev=db85489f0d41#21