Event::GetScreenCoords incorrectly converts the coords to a CSSPoint when the widget is null.

RESOLVED FIXED in Firefox 45

Status

()

Core
Layout
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rbarker, Assigned: rbarker)

Tracking

Trunk
mozilla45
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bug 1220925 incorrectly converts the screen coord to a CSSPoint when the widget is null but the nsPresContext is not. This causes events that were created in JavaScript to return incorrect screen coordinates on devices where the pixel ratio is not 1:1 such as an rMBP.
(Assignee)

Updated

2 years ago
Assignee: nobody → rbarker
Blocks: 1206872
Depends on: 1220925
(Assignee)

Comment 1

2 years ago
Created attachment 8692304 [details] [diff] [review]
0001-Bug-1228216-Event-GetScreenCoords-incorrectly-converts-the-coords-to-a-CSSPoint-when-the-widget-is-null-15112520-744b21c.patch
(Assignee)

Updated

2 years ago
Attachment #8692304 - Flags: review?(tnikkel)
Attachment #8692304 - Flags: review?(tnikkel) → review+
I filed bug 1228466 on the LayoutDeviceIntPoint aPoint argument to this function not actually being in layout device pixels.

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1342a855302d

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1342a855302d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.