1228352 - [Messages] Reduce the flickering happening in activities, and streamline animations

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

STR1:
1. Launch Gallery.
2. Display an image.
3. Share it with Messages.

=> Observe there is a white screen before the right panel is displayed.

STR2:
1. Launch Contacts.
2. Display an contact.
3. Tap the 'send SMS' button.

=> Observe there is a white screen before the right panel is displayed.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] julienw:less-flickering > mozilla-b2g:master

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 8692551 [details] [review]
[gaia] julienw:less-flickering > mozilla-b2g:master

Hey Oleg, what do you think ?

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8692551 [details] [review]
[gaia] julienw:less-flickering > mozilla-b2g:master

Having green background for app-in-activity-mode looks better than current state, and I like the cleanup because of using shared animations.css.

However there is something wrong when we send group message - user is stuck in broken report view - commented at GitHub.

Thanks!

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8692551 [details] [review]
[gaia] julienw:less-flickering > mozilla-b2g:master

Hey Oleg, I think it's now ready for a review !

Comment 5

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8692551 [details] [review]
[gaia] julienw:less-flickering > mozilla-b2g:master

Looks good! I haven't noticed anything weird while testing your PR on device. I've left only very optional nit and one question-suggestion at GitHub.

Thanks!

Comment 6

[Julien Wajsberg [:julienw]]

fixed latest nits and checked it was fine on a device + waited for a green build !

landed:
master: https://github.com/mozilla-b2g/gaia/commit/37bcf558d16088130edafc41561d5c7f8910686a