Closed
Bug 1228445
Opened 9 years ago
Closed 9 years ago
mozmill failures: Assertion failure: loadingPrincipal (please provide aLoadingPrincipal for this favicon)
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 45.0
People
(Reporter: aleth, Assigned: aleth)
References
Details
(Keywords: intermittent-failure, regression)
Attachments
(1 file)
|
7.68 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Debug builds only.
Assertion failure: loadingPrincipal (please provide aLoadingPrincipal for this favicon), at c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/toolkit/components/places/nsFaviconService.cpp:233
|
Assignee | |
Updated•9 years ago
|
Blocks: 1119386
Keywords: regression
|
|
Assignee | |
Comment 1•9 years ago
|
||
See the linked bug for details.
For feeds, I think we should use the system principal, as Firefox does for bookmarks.
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8692669 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8692669 [details] [diff] [review]
Specify loadingPrincipal for favicons
Review of attachment 8692669 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, aleth! r=mkmelin
Attachment #8692669 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/e0ddca365d2c56545194f6647bf41f6b38c1268f
Bug 1228445 - Specify loadingPrincipal for favicons. r=mkmelin
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
You need to log in
before you can comment on or make changes to this bug.
Description
•