"Assertion failure: !Graph() || Graph() == aStream->Graph()"

RESOLVED FIXED in Firefox 44, Firefox OS v2.5

Status

()

Core
Audio/Video: Playback
--
critical
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Jesse Ruderman, Assigned: karlt)

Tracking

(Blocks: 1 bug, {assertion, regression, testcase})

Trunk
mozilla46
assertion, regression, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 affected, firefox43 affected, firefox44 fixed, firefox45 fixed, firefox46 fixed, firefox-esr38 unaffected, b2g-v2.5 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Created attachment 8692796 [details]
testcase

Assertion failure: !Graph() || Graph() == aStream->Graph(), at dom/media/mediasink/DecodedStream.cpp:261
(Reporter)

Comment 1

2 years ago
Created attachment 8692797 [details]
stack
(Assignee)

Updated

2 years ago
Assignee: nobody → karlt
(Assignee)

Updated

2 years ago
Blocks: 1073615
status-firefox42: --- → affected
status-firefox43: --- → affected
status-firefox44: --- → affected
status-firefox-esr38: --- → affected
Component: Web Audio → Audio/Video: Playback
Keywords: regression
(Assignee)

Updated

2 years ago
See Also: → bug 1228559
(Assignee)

Comment 2

2 years ago
I would like to remove support for capturing media elements of one channel to another channel type, but that was explicitly added for bug 1107534, that and the media element channel is mutable.

Adding support for capturing to multiple channels may be possible, but we should prevent this delusion of success for now.
(Assignee)

Comment 3

2 years ago
Created attachment 8695482 [details]
MozReview Request: bug 1228484 throw instead of capturing a second stream to a different graph r?roc

bug 1228484 throw instead of capturing a second stream to a different graph r?roc
Attachment #8695482 - Flags: review?(roc)
Aren't we going to break the B2G stuff in bug 1107534?
Flags: needinfo?(karlt)
(Assignee)

Comment 5

2 years ago
This only affects b2g if it is capturing a single element into two different graphs, which would already be broken.
Flags: needinfo?(karlt)
Comment on attachment 8695482 [details]
MozReview Request: bug 1228484 throw instead of capturing a second stream to a different graph r?roc

https://reviewboard.mozilla.org/r/27129/#review24575
Attachment #8695482 - Flags: review?(roc) → review+

Comment 7

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce9ce7e7d717
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a206e2652fc

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ce9ce7e7d717
https://hg.mozilla.org/mozilla-central/rev/3a206e2652fc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
(Assignee)

Comment 9

2 years ago
The bug fixed by this patch didn't really exist until bug 1107534 landed.  The associated bug from landing bug 1073615, and so affecting esr38, is covered by bug 1223670.
Blocks: 1107534
No longer blocks: 1073615
(Assignee)

Updated

2 years ago
status-firefox-esr38: affected → unaffected
(Assignee)

Comment 10

2 years ago
Comment on attachment 8695482 [details]
MozReview Request: bug 1228484 throw instead of capturing a second stream to a different graph r?roc

Approval Request Comment
[String/UUID change made/needed]:
None
[Feature/regressing bug #]: bug 1107534
[User impact if declined]:
Effects similar to those described in
https://bugzilla.mozilla.org/show_bug.cgi?id=1179484#c10
[Describe test coverage new/current, TreeHerder]:
New test.
[Risks and why]: 
The biggest risk is if b2g is using the feature in a way that is already broken.  If this is the case, an exception will be thrown instead of generating unreliable and crashy audio.
[String/UUID change made/needed]:
None
Attachment #8695482 - Flags: approval-mozilla-beta?
Attachment #8695482 - Flags: approval-mozilla-aurora?
Comment on attachment 8695482 [details]
MozReview Request: bug 1228484 throw instead of capturing a second stream to a different graph r?roc

Has been on Nightly for 10 days, seems safe to uplift to Beta44, Aurora45.
Attachment #8695482 - Flags: approval-mozilla-beta?
Attachment #8695482 - Flags: approval-mozilla-beta+
Attachment #8695482 - Flags: approval-mozilla-aurora?
Attachment #8695482 - Flags: approval-mozilla-aurora+

Comment 12

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/b5969bcd352d
https://hg.mozilla.org/releases/mozilla-aurora/rev/4f950ccc933d
status-firefox45: affected → fixed

Comment 13

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/9fa4dbbe3b52
https://hg.mozilla.org/releases/mozilla-beta/rev/b474d648a74f
status-firefox44: affected → fixed

Comment 14

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9fa4dbbe3b52
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b474d648a74f
status-b2g-v2.5: --- → fixed
You need to log in before you can comment on or make changes to this bug.