1228484 - "Assertion failure: !Graph() || Graph() == aStream->Graph()"

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: !Graph() || Graph() == aStream->Graph(), at dom/media/mediasink/DecodedStream.cpp:261

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Karl Tomlinson (:karlt)]

I would like to remove support for capturing media elements of one channel to another channel type, but that was explicitly added for bug 1107534, that and the media element channel is mutable.

Adding support for capturing to multiple channels may be possible, but we should prevent this delusion of success for now.

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1228484 throw instead of capturing a second stream to a different graph r?roc

bug 1228484 throw instead of capturing a second stream to a different graph r?roc

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Aren't we going to break the B2G stuff in bug 1107534?

Comment 5

[Karl Tomlinson (:karlt)]

This only affects b2g if it is capturing a single element into two different graphs, which would already be broken.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8695482 [details]
MozReview Request: bug 1228484 throw instead of capturing a second stream to a different graph r?roc

https://reviewboard.mozilla.org/r/27129/#review24575

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce9ce7e7d717
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a206e2652fc

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ce9ce7e7d717
https://hg.mozilla.org/mozilla-central/rev/3a206e2652fc

Comment 9

[Karl Tomlinson (:karlt)]

The bug fixed by this patch didn't really exist until bug 1107534 landed.  The associated bug from landing bug 1073615, and so affecting esr38, is covered by bug 1223670.

Comment 10

[Karl Tomlinson (:karlt)]

Comment on attachment 8695482 [details]
MozReview Request: bug 1228484 throw instead of capturing a second stream to a different graph r?roc

Approval Request Comment
[String/UUID change made/needed]:
None
[Feature/regressing bug #]: bug 1107534
[User impact if declined]:
Effects similar to those described in
https://bugzilla.mozilla.org/show_bug.cgi?id=1179484#c10
[Describe test coverage new/current, TreeHerder]:
New test.
[Risks and why]: 
The biggest risk is if b2g is using the feature in a way that is already broken.  If this is the case, an exception will be thrown instead of generating unreliable and crashy audio.
[String/UUID change made/needed]:
None

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8695482 [details]
MozReview Request: bug 1228484 throw instead of capturing a second stream to a different graph r?roc

Has been on Nightly for 10 days, seems safe to uplift to Beta44, Aurora45.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b5969bcd352d
https://hg.mozilla.org/releases/mozilla-aurora/rev/4f950ccc933d

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9fa4dbbe3b52
https://hg.mozilla.org/releases/mozilla-beta/rev/b474d648a74f

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9fa4dbbe3b52
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b474d648a74f