Closed Bug 1228603 Opened 9 years ago Closed 9 years ago

Update pdf.js to version 1.3.42

Categories

(Firefox :: PDF Viewer, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

(Blocks 1 open bug)

Details

+++ This bug was initially created as a clone of Bug #1226621 +++ Changes since last update: #6672 Refactor annotation flags code #6671 Make `stripCommentHeaders` less greedy, to ensure that it doesn't eat 'use strict' directive at the top of files (PR 6627 follow-up) #6676 document_colors_disabled shouldn't escape quotes (compare-locales warning) #6677 Restore the `data.annotationFlags` parameter for annotations (PR 6672 follow-up) #6675 [api-minor] Let `getAnnotations` fetch all annotations by default, unless an intent is specified #6679 Improve the comment and deprecation warning for `PDFJS.openExternalLinksInNewWindow` #6571 [api-minor] Allows a worker to handle multiple documents. #6681 [api-minor] Add a parameter to `PDFPageProxy_getTextContent` that enables replacing of all whitespace with standard spaces in the textLayer (issue 6612) #6693 Worker shall wait for MessageHandler to be created at api side.
Backed out due to test failures on Mac and Linux (at least) such as: https://treeherder.mozilla.org/logviewer.html#?job_id=5942510&repo=fx-team 09:59:34 INFO - 335 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | document content has viewer UI - 09:59:34 INFO - 336 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | window content has PDFJS object - 09:59:34 INFO - 337 INFO TEST-UNEXPECTED-FAIL | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | uncaught exception - TypeError: font.bindDOM is not a function at resource://pdf.js/build/pdf.js:6415 09:59:34 INFO - Stack trace: 09:59:34 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1519 09:59:34 INFO - JavaScript error: resource://pdf.js/build/pdf.js, line 6415: TypeError: font.bindDOM is not a function 09:59:34 INFO - Not taking screenshot here: see the one that was previously logged 09:59:34 INFO - 338 INFO TEST-UNEXPECTED-FAIL | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | uncaught exception - TypeError: font.bindDOM is not a function at resource://pdf.js/build/pdf.js:6415 09:59:34 INFO - Stack trace: 09:59:34 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1519 09:59:34 INFO - JavaScript error: resource://pdf.js/build/pdf.js, line 6415: TypeError: font.bindDOM is not a function 09:59:34 INFO - 339 INFO Console message: [JavaScript Error: "TypeError: font.bindDOM is not a function" {file: "resource://pdf.js/build/pdf.js" line: 6415}] 09:59:34 INFO - fontLoaderBind@resource://pdf.js/build/pdf.js:6415:7 09:59:34 INFO - transportObj@resource://pdf.js/build/pdf.js:2824:1
Flags: needinfo?(ydelendik)
Changes since last update: #6697 Set error font for Type3 if its loading failed. #6700 Replace `font.bindDOM()` with `font.createFontFaceRule()` in the `FontLoader` for MOZCENTRAL specific code (PR 6571 follow-up) Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b3eea060230 Will push to fx-team once that comes back green.
Flags: needinfo?(ydelendik)
Summary: Update pdf.js to version 1.3.38 → Update pdf.js to version 1.3.42
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Blocks: 1230618
Depends on: 1232071
No longer blocks: 1230618
Type: defect → task
No longer depends on: 1226621
You need to log in before you can comment on or make changes to this bug.