Closed Bug 1232071 Opened 6 years ago Closed 6 years ago

The PDF.js showing loading circle. and also stop rendering the pages.

Categories

(Firefox :: PDF Viewer, defect)

45 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 45
Tracking Status
firefox44 --- unaffected
firefox45 --- verified

People

(Reporter: alice0775, Assigned: Snuffleupagus)

References

()

Details

(Keywords: regression, Whiteboard: [pdfjs-f-fixed-upstream] https://github.com/mozilla/pdf.js/pull/6745)

Attachments

(1 file)

Build Identifier:
https://hg.mozilla.org/mozilla-central/rev/754b4805a65cab4f3aca99899227acc44ba4fb20
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 ID:20151211030207

See http://forums.mozillazine.org/viewtopic.php?f=23&t=2978285

Reproducible: Always

Step to reproduce:
1. Open the pdf in new foreground tab
2. Switch to other tabs for at least 1 min(might also need to switch to other software window)
3. Switch back to the pdf tab, resize the Firefox window
4. Scroll to bottom and the scroll to top

Actual Results:
The PDF.js showing loading circle. and also stop rendering the pages.

Expected Results:
It should just showing the loading circle for awhile, then render the pages complete.


Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=3b8b9e4abbaadf1ccd61cb51c8578e36f9d3e004&tochange=996c67a6a11363e13efa4d77a8fe449c3081f221

Regressed by: 996c67a6a113	Ryan VanderMeulen — Bug 1228603 - Update pdf.js to version 1.3.42. r=bdahl
Flags: needinfo?(ryanvm)
¡Hola!

What's seen in the "Browser Console":

TypeError: styleSheet is null pdf.js:6415:5
PDF 8fb7ebb26b6a9847ad0007053ef86730 [1.5 Creo Normalizer JTP / -] (PDF.js: 1.3.56) viewer.js:6862
TypeError: styleElement.parentNode is null pdf.js:6421:7
PDF 8fb7ebb26b6a9847ad0007053ef86730 [1.5 Creo Normalizer JTP / -] (PDF.js: 1.3.56) viewer.js:6862

¡Gracias!
Attached patch bug1232071.patchSplinter Review
Please note: this patch was generated based the patch in bug 1232015 (which is only landed on fx-team as of this writing).
Assignee: nobody → jonas.jenwald
Attachment #8697765 - Flags: review?(ydelendik)
Comment on attachment 8697765 [details] [diff] [review]
bug1232071.patch

Review of attachment 8697765 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good
Attachment #8697765 - Flags: review?(ydelendik) → review+
Ryan, could you please help out with checking in the attached patch?
The patch is quite simple, and fixes a regression that managed to sneak in to bug 1228603.

(I don't have Try access, and I figured that just setting "checkin-needed" would be rejected without a link to a Try run.)
Should be fixed when bug 1232196 is merged to m-c.
Flags: needinfo?(ryanvm)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [pdfjs-f-fixed-upstream] https://github.com/mozilla/pdf.js/pull/6745
Target Milestone: --- → Firefox 45
Alice, can you please verify that this is fixed on your end when you get a chance? :)
Flags: needinfo?(alice0775)
verified, no longer reproduced.
https://hg.mozilla.org/mozilla-central/rev/99137d6d4061f408ae0869122649d8bdf489cc30
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 ID:20151214030220
Flags: needinfo?(alice0775)
Thanks as always!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.