1228604 - Update security/sandbox/chromium/ to Chromium stable channel version 46.0.2490.86

Status: RESOLVED WONTFIX

(Core :: Security: Process Sandboxing, defect)

Description

[Bob Owen (:bobowen)]

Update to commit 2ca4f08cf229279a8c2ed565ac34ebc72f3883b4

Problems:
* "security\sandbox\chromium\base/tuple.h(153) : fatal error C1001: An internal error has occurred in the compiler." - We get this on try and I also get on my laptop, which has a matching cl.exe version (VC2013 Update 3).  This builds on my workstation so I need to check the version there. Probably need an update to the build servers. There is an update 4 and 5.

* empty-body warning for sandbox/linux/services/syscall_wrappers.cc  - easy to add an ignore for this file.

* bad implicit conversion operator failures in static analysis - need to ignore for sandbox/chromium same as for constructor - already have a patch.

* had to roll back a few changes for B2G as they've remove some legacy hash_map support for Android as they don't need it any more. I'm guessing that we would need to update to gcc 4.8 or later to avoid this. We might be able to look at doing that now, but I don't think we need to block on it.

Comment 1

[Rob Thijssen [:grenade (EET/UTC+0300)]]

> Created loaner: y-2008-ec2-bobowen.try.mozilla.org (y-2008-ec2-bobowen.try.releng.use1.mozilla.com) / 10.134.65.5
>  - VS2013 update 5 downloaded (not installed): c:\mozilla-build\Git\bin\curl.exe https://download.microsoft.com/download/A/F/9/AF95E6F8-2E6E-49D0-A48A-8E918D7FD768/VS2013.5.exe -o C:\Users\Administrator\Downloads\VS2013.5.exe

> Created test slaves with VS 2013 update 5 installed (attached to staging (try) master http://dev-master2.bb.releng.use1.mozilla.com:8076):
>  - y-2008-ec2-990: https://secure.pub.build.mozilla.org/builddata/reports/slave_health/slave.html?name=y-2008-ec2-0991
>  - y-2008-ec2-991: https://secure.pub.build.mozilla.org/builddata/reports/slave_health/slave.html?name=y-2008-ec2-0991

@Callek can you or #buildduty sort out Bob's VPN access?

Comment 2

[Bob Owen (:bobowen)]

Attachment: Ignore clang warnings for implicit conversions in Chromium sandbox code.

Just uploading WIP patches for this.

Comment 3

[Bob Owen (:bobowen)]

Attachment: Update to Chromium commit 2ca4f08cf229279a8c2ed565ac34ebc72f3883b4 for sandbox code.

Had to roll back a few changes to get this compiling on B2G.
Some of those were just lines within a changeset, so would want to roll back those changes fully before landing.

Also need to create patch to re-apply the logging changes.

Comment 4

[Justin Wood (:Callek)]

Did this VPN access ever get sorted?

Comment 5

[Bob Owen (:bobowen)]

(In reply to Justin Wood (:Callek) from comment #4)
> Did this VPN access ever get sorted?

Well, I managed to get access to the machine that grenade created, so I guess it did.

Comment 6

[Alin Selagea [:aselagea]]

Well, I can see Bob's email and the AWS instance listed in VPN ACL, but I didn't touch this myself ^^
Anyway, it's good that he is able to access it.

Comment 7

[Bob Owen (:bobowen)]

Doesn't look like I recorded the fact that this was blocked by getting VC2013 update 4 (or 5) onto the build servers.

Comment 8

[Bob Owen (:bobowen)]

Looks like the move to VS2015 solved these build problems, but we can now move to a later version - see bug 1287426.