1232728 - update chromium ipc import to something that doesn't cause clang-cl to choke

Status: RESOLVED INCOMPLETE

(Core :: Security: Process Sandboxing, defect)

Description

[Nathan Froyd [:froydnj]]

clang-cl complains on a number of security/sandbox/chromium files that they implicitly cast between pointer-to-function and pointer-to-object, which it claims is a Microsoft extension.  These files are the major source of fallbacks to MSVC when compiling with clang-cl.

I assume these are fixed upstream, as Chromium is known to compile with clang-cl.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Which files?  If they're fixed upstream, it might have just been by changing the flags to disable that warning, in which case there'd likely be a conspicuous lack of changes to the offending casts between our version and upstream.

(Also I'm pretty sure even NSPR would fail that particular portability warning.)

Comment 2

[Bob Owen (:bobowen)]

I've just added my WIP patches to bug 1228604 for the update to the chromium code I was working on.

I think these compile for all platforms apart from Windows on try.
Windows compiles locally OK, but on try we have an internal compiler error.
They need an update to VS2013 to fix this.

Not sure if this update will address any of the issues you're seeing.