Closed Bug 12289 Opened 21 years ago Closed 21 years ago

[DOGFOOD] When changing folders, selection is messed up

Categories

(SeaMonkey :: MailNews: Message Display, defect, P3, blocker)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: scottputterman, Assigned: scottputterman)

References

Details

(Whiteboard: [PR1])

I'm using the new onselect even in threadpane.  I'm not sure if this makes a
difference.
Open Mailnews
Select a folder.
Select a message in that folder.  Message is displayed
Change to a different folder
Select a message in the new folder. Message isn't displayed.

I've debugged this in my js and it looks like when we change folders, it thinks
the number of selected items is equal to the number of selected items in the
old folder plus the number of selected items in the new folder which means that
no message is displayed since we don't display messages when 2 or more messages
are selected.  In addition, ever message clicked on is added to the selection
without the ctrl or shift keys being pressed.

It looks like selection is not reset when the thread pane tree is rerooted.  I
do happen to know when a new folder is loaded and I could probably clear the
selection myself.  But, it seems like the tree would want to do this.
Status: NEW → ASSIGNED
Target Milestone: M10
This is easy to fix.  I was doing this before.  I just forgot to move it over.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Should be fixed, assuming that nodes are being removed like they should be.
I'm pretty sure I pulled and built the correct files.  I'm stil leeing the same
problem.  I guess that means we have a leak?  I'll try a full build now to make
sure.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
adding hangas to cc.

Right now, will onselect fire when selection is removed?  Such as when you use
the control key to remove selection or when you reroot a tree.  We also need to
know this case.
OK.  I just tried it out and the removing selection with the control key works.
I just wanted to make sure that we get an onselect when rerooting the tree
removes the selection.
Blocks: 7778
I've noticed that if you click twice on the same item, then you get more items
selected:
In ThreadPaneSelectionChange().  Num Selected Items = 3
ctrl-clicking the item reduces this count by one and unselects the current item
visually, but then the next time you click or control-click it goes up again.
Blocks: 12669
Bulk move mail/news M10 bugs to M11
Severity: normal → blocker
This is a dogfood blocker for mail/news so I'm upgrading the severity.

I just saw this bug yesterday, so I think it's not fixed.
Whiteboard: [PR1]
This needs to be fixed for PR1, so I added a note to the Status Whiteboard.

This bug really drives me crazy.
Blocks: 12176
Summary: When changing folders, selection is messed up → [DOGFOOD] When changing folders, selection is messed up
OS: Windows NT → All
Hardware: PC → All
Just an update to note this is on all platforms, changing platform and OS to
all.  Still happens on 19990908 builds.
*** Bug 13496 has been marked as a duplicate of this bug. ***
Update:  tested with 19990914 win32 build, still a problem
We're working on solutions where we will clear out the selection before
switching folders and address books.  I think this should work.  When we get
that working, I'll close out this bug and and open up a new one on the tree
widget.  I think it should still clear out the selection when rerooting, but if
we can work around this, this should be sufficient for beta.
Sorry, that was build 1999091310 M10 build not 19990914
Assignee: hyatt → putterman
Status: ASSIGNED → NEW
Using build 19990915 on win98 this appears to be fixed.  I think a workaround
fix went in so this is more user friendly.  Scott, did you want this marked as
fixed and open a new bug for removing the work around after the real fix goes
in?  Or do we leave this opened and change the severity?  Reassigning to
putterman for review
Status: NEW → RESOLVED
Closed: 21 years ago21 years ago
Resolution: --- → FIXED
This is fixed for the 3pane.  Select a message in one folder.  Change folders,
and then select a new message. This should work now.
QA Contact: lchiang → esther
Need to verify on other platforms.  Win32 1999091508 build is fine.
Status: RESOLVED → VERIFIED
Using 19990922 builds on win98, mac and linux this is fixed for all.  Verified
No longer blocks: 12176
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.