1229056 - Implement ClientQueryOptions.includeUncontrolled

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[(no longer active)]

This can be done relatively easily without needing bug 1032521 as a pre-requisite.

Comment 1

[(no longer active)]

Attachment: Implement ClientQueryOptions.includeUncontrolled

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 8693719 [details] [diff] [review]
Implement ClientQueryOptions.includeUncontrolled

Review of attachment 8693719 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/mozilla/tests/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html
@@ +47,5 @@
> +        return info[0] == 'visible';
> +      });
> +      assert_equals(data.length, expected.length);
> +      for (var i = 0; i < data.length; i++)
> +        assert_array_equals(data[i], expected[i]);

There's no order defined by the spec, right? Can we make this less strict?

Comment 3

[(no longer active)]

(In reply to Josh Matthews [:jdm] from comment #2)
> Comment on attachment 8693719 [details] [diff] [review]
> Implement ClientQueryOptions.includeUncontrolled
> 
> Review of attachment 8693719 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> :::
> testing/web-platform/mozilla/tests/service-workers/service-worker/clients-
> matchall-include-uncontrolled.https.html
> @@ +47,5 @@
> > +        return info[0] == 'visible';
> > +      });
> > +      assert_equals(data.length, expected.length);
> > +      for (var i = 0; i < data.length; i++)
> > +        assert_array_equals(data[i], expected[i]);
> 
> There's no order defined by the spec, right? Can we make this less strict?

Correct.

The test sorts the array before comparison, so it doesn't depend on the order in which the implementation returns this stuff.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8cc99a3321c

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e8cc99a3321c

Comment 6

[Chris Mills [:cmills]]

This is documented, see:

https://developer.mozilla.org/en-US/docs/Web/API/Clients/matchAll

A note has also been added to the relevant release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/45#Service_Workers