Closed Bug 1229341 Opened 4 years ago Closed 4 years ago

Remove .source flag on BRANDING_FILES

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

The only use of BRANDING_FILES[...].source is in xulrunner/app/moz.build, for the app.ico file.

This file has not been useful since the removal of the xpinstall-based installer in bug 344236... 9 years ago.
Comment on attachment 8694157 [details] [diff] [review]
Remove .source flag on BRANDING_FILES

Review of attachment 8694157 [details] [diff] [review]:
-----------------------------------------------------------------

We have a new winner for the cargo cult award. This was bound to happen with our approach of blindly converting things from Makefile.in to moz.build though.
Attachment #8694157 - Flags: review?(gps) → review+
Comment on attachment 8694158 [details] [diff] [review]
Remove HierarchicalStringListWithFlagsFactory

Review of attachment 8694158 [details] [diff] [review]:
-----------------------------------------------------------------

Sure. We can always revive it if we need to.
Attachment #8694158 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/249b4d65a351
https://hg.mozilla.org/mozilla-central/rev/917c97129ea8
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.