Closed
Bug 1229341
Opened 8 years ago
Closed 8 years ago
Remove .source flag on BRANDING_FILES
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox45 fixed)
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
7.05 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
11.19 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
The only use of BRANDING_FILES[...].source is in xulrunner/app/moz.build, for the app.ico file. This file has not been useful since the removal of the xpinstall-based installer in bug 344236... 9 years ago.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8694157 -
Flags: review?(gps)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8694158 -
Flags: review?(gps)
Comment 3•8 years ago
|
||
Comment on attachment 8694157 [details] [diff] [review] Remove .source flag on BRANDING_FILES Review of attachment 8694157 [details] [diff] [review]: ----------------------------------------------------------------- We have a new winner for the cargo cult award. This was bound to happen with our approach of blindly converting things from Makefile.in to moz.build though.
Attachment #8694157 -
Flags: review?(gps) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8694158 [details] [diff] [review] Remove HierarchicalStringListWithFlagsFactory Review of attachment 8694158 [details] [diff] [review]: ----------------------------------------------------------------- Sure. We can always revive it if we need to.
Attachment #8694158 -
Flags: review?(gps) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/249b4d65a351 https://hg.mozilla.org/integration/mozilla-inbound/rev/917c97129ea8
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/249b4d65a351 https://hg.mozilla.org/mozilla-central/rev/917c97129ea8
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•