344236 - Remove xpinstall-based installer code

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Benjamin Smedberg]

The xpinstall-based toolkit installer can almost go. The Linux code is currently unused, and the Windows code is only used by Thunderbird and (I think?) will be ported to use the NSIS installer soon.

Comment 1

[Axel Hecht [:Pike]]

Thunderbird moved over, AFAICT, does this affect SeaMonkey?

I filed bug 345846, which I would hope to land on the 1.8 branch, as it makes localization easier quite a bit, in the light of new locales on 2.0.0.x, too. So the question I'd have is, does it make sense to have that bug open separately or is it a plain dupe?

Comment 2

[Benjamin Smedberg]

Keep that open separately... I have no plans to do this on the 1.8branch, and it's relatively low priority.

This doens't affect seamonkey at the moment because they are still using the xpinstall/... installer.

Comment 3

[Benjamin Smedberg]

Attachment: Remove xpinstall-based installer, rev. 1

This is almost everything. I didn't know who used some of the scripts in toolkit/mozapps/installer, so I didn't touch those yet.

diff -u4 2>&1 so that you can see what I removed without having to wade through the actual contents of the files.

Comment 4

[Robert Strong (they/them - no direct email)]

Benjamin, I'd like to hold off on this until bug 349551 is fixed.

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 234776 [details] [diff] [review]
Remove xpinstall-based installer, rev. 1

>Index: toolkit/mozapps/Makefile.in
...
>-# XXX SUITE doesn't want to build the toolkit installer yet
>-ifndef MOZ_SUITE
>-# The installer is built during the packaging phase, but the uninstaller needs
>-# to be built earlier.
>-ifdef MOZ_INSTALLER
>-ifeq ($(OS_ARCH),WINNT)
>-DIRS += installer/windows/wizard/uninstall
>-endif
>-endif
>-endif
removed by the patch in bug 349551

>cvs diff: toolkit/mozapps/installer/windows/wizard/setup/setup.ico was removed, no comparison available
setup.ico is still needed and is moved to toolkit/mozapps/installer/windows/nsis by the patch in bug 349551

toolkit/mozapps/installer/windows/install_sub.pl can also be removed
toolkit/mozapps/installer/Makefile.in can also be removed. 

allmakefiles.sh needs to be updated for these changes
-toolkit/mozapps/installer/unix/wizard/Makefile
-toolkit/mozapps/installer/unix/Makefile
-toolkit/mozapps/installer/Makefile
-toolkit/mozapps/installer/windows/Makefile
-toolkit/mozapps/installer/windows/wizard/Makefile
-toolkit/mozapps/installer/windows/wizard/setup/Makefile
-toolkit/mozapps/installer/windows/wizard/setuprsc/Makefile
-toolkit/mozapps/installer/windows/wizard/uninstall/Makefile

It would be nice to also remove the following from allmakefiles.sh at the same time
extensions/inspector/build/src/Makefile
mozilla/browser/extensions/package-fixup/Makefile.

If you like I can probably do the browser portion in about a week.

r=me but please wait on bug 349551 landing before landing this.

Comment 6

[Benjamin Smedberg]

Fixed on trunk.

Comment 7

[Robert Strong (they/them - no direct email)]

Almost got them all... I missed the following icon that can be removed
mozilla/toolkit/mozapps/installer/windows/wizard/setuprsc/setup.ico

Comment 8

[Robert Strong (they/them - no direct email)]

Removed /toolkit/mozapps/installer/windows/wizard/setuprsc/setup.ico with a verbal r= from bsmedberg on irc