1229349 - Tapping on things in the zoomed view is broken with C++ APZ

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

This was working previously but seems to have broken again. I was zoomed out on a page when I tried tapping on a link. Up came the zoomed view and tapping on the link in the view just shifted the position of the view slightly rather than sending a click.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This actually seems to be working, at least the last few times I've encountered the zoomed view. It probably needs some more testing just to make sure though.

Comment 2

[:Margaret Leibovic]

This came up in triage last week, but I didn't realize there was already a bug filed on this.

I was under the impression that the zoomed view is very broken with APZ, and that it would be a lot of work to fix it. snorp, is that the case?

If this is going to be a lot of work to fix, we need to re-evaluate the product priority of whether we should ship this feature, given that we haven't even shipped it yet. If we decide not to ship it, we'll need to uplift a patch to disable it on 45.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Yeah, I think it will take a significant amount of effort. With all of the other problems ongoing with APZ, it's just another thing that will keep us from shipping.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

FWIW I don't think it'll take any more effort than what we already need to do to get APZ shipping on Fennec.

Comment 5

[:Margaret Leibovic]

There is enough work blocking APZ, I don't think we should take on this dependency as well.

Let's disable the zoomed view until after APZ is ready to ship, and then we can re-assess. Given that we haven't shipped the zoom view yet, I also think we should uplift the patch to disable it to 45, so that we don't ship it for some releases and then disable it again.

Comment 6

[Barbara Bermes [:barbara] - NI please!]

Dominique, please let us know if you need more info around this, otherwise let's regroup after APZ is ready to ship.

Comment 7

[Dominique Vincent [:domivinc]]

(In reply to Barbara Bermes [:barbara] from comment #6)
> Dominique, please let us know if you need more info around this, otherwise
> let's regroup after APZ is ready to ship.

I think that the zoomed view is already deactivated by the code change done in bug 1247095. :snorp reviewed this code change, and could probably manage an uplift of bug 1247095 if it's required (the target of bug 1247095 is Firefox 47).

Comment 8

[Kartikaya Gupta (email:[e-mail])]

I had this pop up yesterday and I spent a few minutes testing, it seems like it works fine. I'm going to close this bug, if we run into specific cases where it doesn't work we can file bugs for those.