Closed Bug 1229418 Opened 8 years ago Closed 8 years ago

Need BB emulator builds + tests for b2g-ota branch

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hwine, Assigned: hwine)

References

Details

(Whiteboard: [b2g-ota])

Attachments

(2 files, 2 obsolete files)

+++ This bug was initially created as a clone of Bug #1227355 +++

+++ This bug was initially created as a clone of Bug #1218059 +++
Attached patch 1229418-bbconfigs.patch (obsolete) — Splinter Review
Assignee: nobody → hwine
Status: NEW → ASSIGNED
Attachment #8694385 - Flags: review?
Attachment #8694419 - Flags: review?
Attached patch 1229418-tools.patch (obsolete) — Splinter Review
Attachment #8694422 - Flags: review?
Comment on attachment 8694422 [details] [diff] [review]
1229418-tools.patch

Review of attachment 8694422 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this already landed at http://hg.mozilla.org/build/tools/rev/e2810fde2a27
Attachment #8694422 - Flags: review?
Attachment #8694419 - Flags: review? → review+
Comment on attachment 8694385 [details] [diff] [review]
1229418-bbconfigs.patch

Review of attachment 8694385 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing review until improved patch arrives.
Attachment #8694385 - Flags: review?
passes test-masters.sh
Attachment #8694385 - Attachment is obsolete: true
Attachment #8694471 - Flags: review?(nthomas)
Attachment #8694422 - Flags: review?(nthomas)
Comment on attachment 8694471 [details] [diff] [review]
1229418-bbconfigs-2.patch

Review of attachment 8694471 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with a few tweaks, the main one being the repo_path in mozilla/b2g_config.py

::: mozilla-tests/b2g_config.py
@@ +49,5 @@
>          'b2g_version': (2, 5, 0),
>      },
> +    'b2g-ota': {
> +        'gecko_version': 45,
> +        'b2g_version': (2, 6, 0),

These presumably get bumped on merge days, so need to flag that up somehow. Same for mozilla/b2g_config.py

::: mozilla/b2g_config.py
@@ +992,5 @@
> +            'linux64-b2g-haz': {},
> +            'emulator': {},
> +            'emulator-debug': {},
> +            'emulator-l': {},
> +            'emulator-l-debug': {},

Lets drop these two emulator-l lines, since we're not running them on m-c.

@@ +1140,5 @@
>  
> +######## b2g-ota
> +# This is a path, relative to HGURL, where the repository is located
> +# HGURL + repo_path should be a valid repository
> +BRANCHES['b2g-ota']['repo_path'] = 'b2g-ota'

'releases/b2g-ota'

::: mozilla/build_localconfig.py
@@ +34,5 @@
>          'mozilla-esr38',
>          'mozilla-b2g37_v2_2',
>          'mozilla-b2g37_v2_2r',
>          'mozilla-b2g44_v2_5',
> +        'b2g-ota',

I tried disabling this one and the number of new builders didn't change, presumably because we're not doing mulet/b2g desktop builds. I could go either way on leaving it in/removing.
Attachment #8694471 - Flags: review?(nthomas) → review+
Comment on attachment 8694422 [details] [diff] [review]
1229418-tools.patch

Already snuck into the file.
Attachment #8694422 - Attachment is obsolete: true
Attachment #8694422 - Flags: review?(nthomas)
Comment on attachment 8694471 [details] [diff] [review]
1229418-bbconfigs-2.patch

checked in on default, taking all suggestions from
(In reply to Nick Thomas [:nthomas] from comment #7)
> Comment on attachment 8694471 [details] [diff] [review]
> 1229418-bbconfigs-2.patch
> 
> Review of attachment 8694471 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+ with a few tweaks, the main one being the repo_path in
> mozilla/b2g_config.py
> 
> ::: mozilla-tests/b2g_config.py
> @@ +49,5 @@
> >          'b2g_version': (2, 5, 0),
> >      },
> > +    'b2g-ota': {
> > +        'gecko_version': 45,
> > +        'b2g_version': (2, 6, 0),
> 
> These presumably get bumped on merge days, so need to flag that up somehow.
> Same for mozilla/b2g_config.py

Opened bug 1229617 opened for this

> ::: mozilla/build_localconfig.py
> @@ +34,5 @@
> >          'mozilla-esr38',
> >          'mozilla-b2g37_v2_2',
> >          'mozilla-b2g37_v2_2r',
> >          'mozilla-b2g44_v2_5',
> > +        'b2g-ota',
> 
> I tried disabling this one and the number of new builders didn't change,
> presumably because we're not doing mulet/b2g desktop builds. I could go
> either way on leaving it in/removing.

I removed to avoid future confusion.
Attachment #8694471 - Flags: checked-in+
Attachment #8694419 - Flags: checked-in+
And, we're done
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: