1229494 - upgrade hg to 3.7.3

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Jordan Lund (:jlund)]

12:01:02 <gps> jlund: `hg branches` and `hg tags` could spin CPU for a *long* time on old Mercurial versions. mostly fixed in 3.4+
12:01:52 <gps> strace likely won't report anything because it all CPU inside Python that doesn't perform any system calls monitored by strace by default
12:02:00 <gps> likely only malloc, etc
12:02:41 <jlund> though I'm all on board with upgrading hg, I can't do that to unblock this current release in flight
12:05:19 <jlund> gps: hwine: any other ideas?
12:05:53 <jlund> can we clean up the repo? I'm wondering if it has 1 too many branches for our old hg version to handle :)
12:06:54 <hwine-coffee> jlund: have you tried the workaround from last time of catting the fd?
12:07:25 <jlund> not yet. I am assuming this will happen for every release...
12:08:01 <gps> you could upgrade mercurial to 3.6.1 and get all the bug fixes and performance improvements
12:08:10 <jlund> but I can try that, and file a bug to upgrade to new hg
12:16:06 <gps> i'll be honest - i find it difficult to help debug possible mercurial issues when you are running a release that's so old

Comment 1

[Gregory Szorc [:gps]]

Wait a day or 2 and 3.6.2 should be released. You should upgrade to that.

Comment 2

[Gregory Szorc [:gps]]

3.6.2 is released.

Comment 3

[Chris Cooper [:coop] (he/him)]

Pushing forward with this, targeting 3.6.3.

Comment 4

[Gregory Szorc [:gps]]

If you go with 3.7.1+, `hg clone --uncompressed` / clone with "streaming clone bundles" is 3-4x faster on Windows. That improvement came as a result of RelEng's Windows people noticing how slow `hg clone` was on Windows. But I can't blame you for wanting to wait until 3.7.2, which should be released ~March 1 unless there is another unscheduled point release before. Also, Python wheels for 3.7 are now available at https://pypi.python.org/pypi/Mercurial/.

Comment 5

[Chris Cooper [:coop] (he/him)]

Oh, I fully intend to *also* update to 3.7.2 once it's available, but I want us to get better/faster at the upgrade process.

Comment 7

[Gregory Szorc [:gps]]

Let's use this bug to track the planned upgrade to 3.7.2 this week.

Comment 8

[Gregory Szorc [:gps]]

https://s3-us-west-2.amazonaws.com/moz-packages/CentOS6/mercurial-3.7.2-1.x86_64.rpm (sha256: cc67d5809571e706268a675d6bae9d1dc6baa2f4fda0d94dd2b90b8f8421d510) can be installed on CentOS6 / RHEL6 machines. This is the same RPM we're currently using on hg.mozilla.org. Although it runs with the system Python (which is 2.6). On hg.mo, we install Mercurial into a virtualenv and run via Python 2.7.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Still early enough to switch to 3.7.3 for the sec fixes and issue 5103 ? https://www.mercurial-scm.org/wiki/WhatsNew for the changelog.

Comment 10

[Gregory Szorc [:gps]]

At this point 3.7.3 should be installed everywhere.