1229567 - back out data: URL hack from bug 1194856

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

We probably want to back out the hack in https://hg.mozilla.org/mozilla-central/rev/d05b4fbebba8 .  I think the conclusion was that it didn't help anything, although I'm not sure.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Is it correct that this didn't help?  Should we revert it?

Comment 2

[Cameron McCormack (:heycam)]

That's right, it didn't help and we should back it out.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 4

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1560b0d9634b

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8701371 [details] [diff] [review]
patch

(I see dbaron's review queue is a bit long at the moment, so moving this (and a couple of others) over to dholbert.)

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 8701371 [details] [diff] [review]
patch

Review of attachment 8701371 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not reviewing the details of this patch too closely, since IIUC it's just reverting an experiment that didn't pan out.

I did discover one minor nit from doing an explicit backout (of d05b4fbebba8) locally myself, and diffing it against your attached patch.  r=me with that nit addressed.

::: layout/style/nsLayoutStylesheetCache.cpp
@@ +206,5 @@
>    EnsureGlobal();
>  
>    if (!gStyleCache->mNoFramesSheet) {
>      // If you update the data: URL, also update noframes.css  (See bug 1194856.)
> +    LoadSheetURL("resource://gre-resources/noframes.css",

The comment here ("If you update the data: URL") needs removing, to make the backout complete. (and because you're removing the data URL that the comment refers to)

Comment 7

[Cameron McCormack (:heycam)]

Thanks, yes I'll remove the comment too.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5b153e5a81e

Comment 9

[Guilherme Lima]

https://hg.mozilla.org/mozilla-central/rev/a5b153e5a81e (landed this morning)