1229649 - Eliminate nulls in out parameter for nsIURI

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Kent James (:rkent)]

Many calls in mailnews code pass a URI to the caller which is rarely used. When unused, mailnews code typically passes a nullptr. That nullptr causes a crash in XPCOM code that access Javascript. At some point Bienvenu objected to simply removing the rarely-used nsIURI outparm (can't find the bug number), so replace those with a dummy parameter instead.

This is needed for JsAccount.

Comment 1

[Kent James (:rkent)]

Attachment: Replace nullptr with dummyNull

I considered changing the interfaces to eliminate the out nsIURI, but that would be more disruptive.

Comment 2

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8694599 [details] [diff] [review]
Replace nullptr with dummyNull

Review of attachment 8694599 [details] [diff] [review]:
-----------------------------------------------------------------

rs+

I remember hitting this issue years ago when I tried my crazy magic variant.

Comment 3

[Kent James (:rkent)]

https://hg.mozilla.org/comm-central/rev/7b180f673933