Eliminate nulls in out parameter for nsIURI

RESOLVED FIXED in Thunderbird 45.0

Status

MailNews Core
Backend
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: rkent, Assigned: rkent)

Tracking

(Blocks: 1 bug)

Thunderbird 45.0

Thunderbird Tracking Flags

(thunderbird44 wontfix, thunderbird45 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Many calls in mailnews code pass a URI to the caller which is rarely used. When unused, mailnews code typically passes a nullptr. That nullptr causes a crash in XPCOM code that access Javascript. At some point Bienvenu objected to simply removing the rarely-used nsIURI outparm (can't find the bug number), so replace those with a dummy parameter instead.

This is needed for JsAccount.
(Assignee)

Comment 1

3 years ago
Created attachment 8694599 [details] [diff] [review]
Replace nullptr with dummyNull

I considered changing the interfaces to eliminate the out nsIURI, but that would be more disruptive.
Assignee: nobody → rkent
Status: NEW → ASSIGNED
Attachment #8694599 - Flags: review?(Pidgeot18)
Comment on attachment 8694599 [details] [diff] [review]
Replace nullptr with dummyNull

Review of attachment 8694599 [details] [diff] [review]:
-----------------------------------------------------------------

rs+

I remember hitting this issue years ago when I tried my crazy magic variant.
Attachment #8694599 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/comm-central/rev/7b180f673933
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-thunderbird44: --- → wontfix
status-thunderbird45: --- → fixed
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Target Milestone: --- → Thunderbird 45.0
(Assignee)

Updated

a year ago
See Also: → bug 1334954
You need to log in before you can comment on or make changes to this bug.