1229831 - Bookmarked tab groups were titled "Group (null)"

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: Screen Shot 2015-12-02 at 2.55.18 PM.png

Today when I updated my nightly to the post-panorama removal version, I got the bookmarked groups like in the screenshot.  There are two numbered groups (Group 1 and 2), and all others were named "Group (null)".

Group 1 was the main group that I used, which I hadn't given any title. Group 2 was the single group from a different window that I had. All other groups were part of window 1, and I had given names to all of them.

The names appear correctly in aboutTabGroupsMigration.xhtml

Comment 1

[:Gijs (he/him)]

This is because this code:

https://dxr.mozilla.org/mozilla-central/source/browser/modules/TabGroupsMigrator.jsm#214-223

removes the title information and sticks it in a separate property, and I restructured the code at a late point in its lifetime so that that particular method ran before the bookmarks creation, instead of after. I assumed the unit tests would catch issues, but I forgot to use the same restructuring there:

https://dxr.mozilla.org/mozilla-central/source/browser/modules/test/xpcshell/test_TabGroupsMigrator.js#80-113

and so they didn't catch this. :-(

Comment 2

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1229831 - tab group migration code loses group titles, r?felipe

Bug 1229831 - tab group migration code loses group titles, r?felipe

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8694828 [details]
MozReview Request: Bug 1229831 - tab group migration code loses group titles, r?felipe

https://reviewboard.mozilla.org/r/26897/#review24303

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/33a59952118a

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/33a59952118a

Comment 7

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on the latest nightly46(updated from nightly 44 to nightly 46) and aurora45(updated from aurora 44 to aurora 45) on the following OS.: Ubuntu14.04 x86, Windows 7 x64, Mac OSX 10.10:


Aurora45:
20151221004011 Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Firefox/45.0
20151221004011 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Firefox/45.0
20151221004011 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0

Nightly46:
20151221030239 Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0
20151221030239 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:46.0) Gecko/20100101 Firefox/46.0
20151220030223, Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0