Limit the number of records fetched per collection

RESOLVED FIXED in 2.6 S2 - 12/4

Status

P1
blocker
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ferjm, Assigned: ferjm)

Tracking

unspecified
2.6 S2 - 12/4
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Assignee: nobody → ferjmoreno
Blocks: 824026
Severity: normal → blocker
Priority: -- → P1
Target Milestone: --- → 2.6 S2 - 12/4
Created attachment 8695406 [details] [review]
[gaia] ferjm:bug1230224.sync.limit > mozilla-b2g:master
Apart from TreeHerder, LGTM!

* I'll see if I can adapt the unit tests to this change, so that tests pass.
* We should do an official update of Kinto.js with https://github.com/Kinto/kinto.js/issues/277 implemented.
* In manual testing, I saw quite a random selection of links show up (all very similar link from one browsing session), probably because the first 50 history entries that come in are not the ones with highest frecency. But I guess that's not a huge problem.
* We should follow up with more profound improvements to how Kinto.js syncs and how the DataAdapters retrieve records (we need to stop using Kinto.Collection#list and implement a proper memory-efficient cursor).
(Assignee)

Comment 3

3 years ago
Comment on attachment 8695406 [details] [review]
[gaia] ferjm:bug1230224.sync.limit > mozilla-b2g:master

Tests looks good now.

Take into account that landing this patch reintroduces the fix for bug 1224203 which was backout so you either need to land a fix for that after this one or change the kinto.js version that is included within this PR.

I am about to take a flight so I'm gonna be offline at least for the next 9 hours, but you can ask Francisco to land the patches.

Thanks!
Attachment #8695406 - Flags: review?(mbdejong)
Great!

Niko is working on https://github.com/Kinto/kinto.js/pull/279, I'll prepare the patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1224203#c8 so that we can merge with an official Kinto.js version.

We can discuss the follow-up improvements for Kinto.js in Orlando.
Attachment #8695406 - Flags: review?(mbdejong) → review+
Niko's work will take a bit longer, so let's merge this patch now and then update Kinto.js to the next version when it comes out. Francisco, could you please do the merge? TreeHerder is green now, so I think we should be good to go.
Flags: needinfo?(francisco)
(Assignee)

Comment 6

3 years ago
https://github.com/mozilla-b2g/gaia/commit/b930e25e9f2e5ec2106dd31005468575cdf87d50
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(francisco)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.