Closed
Bug 1230471
Opened 8 years ago
Closed 8 years ago
Places should pass eslint
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | verified |
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file)
Let's fix Places code in browser and toolkit to pass mach eslint
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/31143/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/31143/
Attachment #8708671 -
Flags: review?(felipc)
Comment 2•8 years ago
|
||
Comment on attachment 8708671 [details] MozReview Request: Bug 1230471 - Basic eslint fixes in places. r=mconley https://reviewboard.mozilla.org/r/31143/#review27963 I'm willing to sign off on this! Thanks mak! ::: toolkit/components/places/BookmarkHTMLUtils.jsm:1048 (Diff revision 1) > - _writeContainer: function (aItem, aIndent = "") { > + *_writeContainer(aItem, aIndent = "") { Oooh - I didn't know star functions could be defined like this too. Neat. ::: toolkit/components/places/tests/unit/test_420331_wyciwyg.js:21 (Diff revision 1) > + if (ex.result != Cr.NS_ERROR_ILLEGAL_VALUE) { > + throw ex; > + } Nit - one more space.
Attachment #8708671 -
Flags: review+
Assignee | ||
Comment 3•8 years ago
|
||
Tahnks. Unfortunately fixing the errors has uncovered some real test failures (hidden due to forEach(...yield...). So I must debug those and figure if they are real regressions we never noticed, before I can land this.
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8708671 [details] MozReview Request: Bug 1230471 - Basic eslint fixes in places. r=mconley Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31143/diff/1-2/
Attachment #8708671 -
Attachment description: MozReview Request: Bug 1230471 - Basic eslint fixes in places. r=felipe → MozReview Request: Bug 1230471 - Basic eslint fixes in places. r=mconley
Attachment #8708671 -
Flags: review?(felipc)
Assignee | ||
Comment 5•8 years ago
|
||
ok, luckily it was just minor details!
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/912c7cf04f01
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment 8•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
Assignee | ||
Comment 9•8 years ago
|
||
if this wouldn't work the tree would show failures.
Status: RESOLVED → VERIFIED
Assignee | ||
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•