1230471 - Places should pass eslint

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

Let's fix Places code in browser and toolkit to pass mach eslint

Comment 1

[Marco Bonardo [:mak]]

Attachment: MozReview Request: Bug 1230471 - Basic eslint fixes in places. r=mconley

Review commit: https://reviewboard.mozilla.org/r/31143/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31143/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8708671 [details]
MozReview Request: Bug 1230471 - Basic eslint fixes in places. r=mconley

https://reviewboard.mozilla.org/r/31143/#review27963

I'm willing to sign off on this! Thanks mak!

::: toolkit/components/places/BookmarkHTMLUtils.jsm:1048
(Diff revision 1)
> -  _writeContainer: function (aItem, aIndent = "") {
> +  *_writeContainer(aItem, aIndent = "") {

Oooh - I didn't know star functions could be defined like this too. Neat.

::: toolkit/components/places/tests/unit/test_420331_wyciwyg.js:21
(Diff revision 1)
> +   if (ex.result != Cr.NS_ERROR_ILLEGAL_VALUE) {
> +      throw ex;
> +    }

Nit - one more space.

Comment 3

[Marco Bonardo [:mak]]

Tahnks. Unfortunately fixing the errors has uncovered some real test failures (hidden due to forEach(...yield...). So I must debug those and figure if they are real regressions we never noticed, before I can land this.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8708671 [details]
MozReview Request: Bug 1230471 - Basic eslint fixes in places. r=mconley

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31143/diff/1-2/

Comment 5

[Marco Bonardo [:mak]]

ok, luckily it was just minor details!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/912c7cf04f01

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/912c7cf04f01

Comment 8

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS				Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected

Comment 9

[Marco Bonardo [:mak]]

if this wouldn't work the tree would show failures.