1230582 - Action Bar is not invoked when tapping an empty search text area

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Go to imdb.com
2. Tap the search text box to invoke action bar

Expected results:
- Action bar is displayed

Actual results:
- Nothing happens

Note:
- when some letters are typed in the search box, the action bar is invoked

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Teodora, what are you calling the action bar here? Perhaps you have a screenshot? I wouldn't expect it to appear when tapping the search text box.

Comment 2

[Teodora Vermesan (:TeoVermesan)]

Attachment: tmp_5916-Screenshot_2015-12-04-23-47-36-233040958.png

The action bar contains the "Paste" and "Add as a search engine" options.
I have 23-11 nightly build and works ok.
On latest Nightly, the action bar does not appear on tap/long tap/ double tap.

Comment 3

[Teodora Vermesan (:TeoVermesan)]

Regression:
Good build: 03-12
Bad build: 04-12

Pushlog http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=31fc97d173b3e3da5de35d54018855e6c905787e&tochange=e02b17a2b5b8df7bb84f325fc08eedd2f3cab755

Comment 4

[Teodora Vermesan (:TeoVermesan)]

Fx-team regression:

1449163461: not affected 		
1449167604: affected

pushlog: http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=4c9ca7614d701d28549ef734d41dcce5ac37cba2&tochange=65b8c89ff1b737c5e58523b6faf89299ca674e4e

Bug 1215959?

Comment 5

[Mark Capella [:capella]]

fyi, this is designed to follow FF/OS (the new AccessibleCarets spec/implementation) ... see [0], around page 10, "Empty Input"

[0] https://bugzilla.mozilla.org/attachment.cgi?id=8548759

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

On B2G, when long-pressing on an empty input, the copy/paste/cut menu will be shown. The float bubble listens to CaretStateChanged event with reason CaretChangedReason::Longpressonemptycontent in [1]. However, the spec in page 9 indicates that only show the cursor without a blue caret.

Does ActionBar show only when the carets are visually visible? Or does the ActionBar show when carets are logically visible as well? If Fennec UX requires that the blue caret shows when the input is empty like the old Fennec did, I could help add a preference to control that.

[1] https://dxr.mozilla.org/mozilla-central/rev/2bdd9ec79799eff3ceec0a318f5a0632d918a527/layout/base/AccessibleCaretManager.cpp#469

Comment 8

[Mark Capella [:capella]]

tylin, yes the current actionbar state follows actual caret visibility, opening [0] ... Looks like you'd tweak a pref here? [1] 

[0] http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/ActionBarHandler.js?rev=2d4cfc1c9e97&mark=36-36#28
[1] http://mxr.mozilla.org/mozilla-central/source/layout/base/AccessibleCaret.cpp?rev=169d9adca23f&mark=256-256#241

Comment 9

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

I'll add sCaretsExtendedVisibility in [1] and probably with some tests so that the blue caret is shown on an empty input on Fennec.

[1] https://dxr.mozilla.org/mozilla-central/rev/319be5e7ce3061c7c16f24d750b6dacdbcac4c35/layout/base/AccessibleCaretManager.cpp#262

Comment 10

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Always show caret even if input is empty on Fennec. f=capella, r=roc

Comment 11

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8700507 [details] [diff] [review]
Always show caret even if input is empty on Fennec. f=capella, r=roc

Mark, would you help test whether this patch works on Fennec?

Comment 12

[Mark Capella [:capella]]

Comment on attachment 8700507 [details] [diff] [review]
Always show caret even if input is empty on Fennec. f=capella, r=roc

Review of attachment 8700507 [details] [diff] [review]:
-----------------------------------------------------------------

Nice ! This works for me :-)

Comment 13

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=43716e6e0855

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df0941b629c3

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df0941b629c3

Comment 16

[u549602]

Verified as fixed on the latest Nightly build (46.0a1 / 2015-12-27) on Nexus tab 7 with Android 5.1.1, Samsung Galaxy Tab S2 with Android 5.0.2 and on Samsung Galaxy S6 Edge, also with Android 5.1.1