Closed
Bug 1230643
Opened 9 years ago
Closed 9 years ago
Test titles are overly verbose when testname == suite
Categories
(Tree Management :: Perfherder, defect)
Tree Management
Perfherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: parkouss)
Details
(Whiteboard: perfherder-starter-bug)
User Story
Thank you for helping out with Treeherder! You can find us on IRC at irc://irc.mozilla.org/treeherder Here's some links to help get you started. Project page: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder https://wiki.mozilla.org/Auto-tools/Projects/Perfherder Interacting with us, repo locations and links to set up a development version of the software: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Contributing https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Source_and_Docs A-Team general reference, coding style guides: https://ateam-bootcamp.readthedocs.org
Attachments
(1 file)
For example, `sessionrestore_no_auto_restore`. It's way too long once, let alone twice. :)
https://treeherder.mozilla.org/perf.html#/graphs?series=[mozilla-inbound,efaeb8a25bc6de40d38a0be504fb9125e1d9642f,1]
I think we can just modify this function to get better behaviour: https://github.com/mozilla/treeherder/blob/master/ui/js/perf.js#L16
Reporter | ||
Updated•9 years ago
|
Whiteboard: perfherder-hackfest-mozlando
Reporter | ||
Updated•9 years ago
|
Whiteboard: perfherder-hackfest-mozlando → perfherder-starter-bug
Reporter | ||
Updated•9 years ago
|
User Story: (updated)
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → j.parkouss
Assignee | ||
Comment 1•9 years ago
|
||
So, that should do the job! This is looking good with the example provided at least. I'm not familiar yet with sending patches for perfherder, so if something is missing, tell me. :)
Attachment #8696854 -
Flags: review?(wlachance)
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8696854 [details] [review]
avoid printing the test name twice
This is good, however I don't *think* it will work for cases with abbreviated output, e.g. see tresize here:
https://treeherder.mozilla.org/perf.html#/alerts?id=1635
(if I'm wrong, let me know)
Attachment #8696854 -
Flags: review?(wlachance) → review-
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8696854 [details] [review]
avoid printing the test name twice
Oh yeah, I did not understood that the abbreviated part also needed to be fixed. So this should be better now, tell me if something is still not good.
Attachment #8696854 -
Flags: review- → review?(wlachance)
Comment 4•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/ea6d59c02f53b3ad6b11944ae8adcd654de2e942
Bug 1230643 - Test titles are overly verbose when testname == suite
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•9 years ago
|
Attachment #8696854 -
Flags: review?(wlachance) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•