Closed Bug 1230701 Opened 7 years ago Closed 7 years ago

will-change:position should cause creation of containing block for absolutely positioned elements

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: css3)

Attachments

(2 files)

MozReview Request: Bug 1230701 - Make will-change:position create a containing block for absolutely-positioned elements. r?dholbert
40 bytes, text/x-review-board-request
dholbert
: review+
Details
MozReview Request: Bug 1230701 - Add test that position does not create a fixed-position containing block. r?dholbert
40 bytes, text/x-review-board-request
dholbert
: review+
Details 
This is a followup to bug 1227766 based on clarifications to the will-change spec that Tab made today.

will-change:position should cause the creation of a containing block for absolutely positioned elements.
URL: css3
Keywords: css3
Assignee: nobody → dbaron
Bug 1230701 - Make will-change:position create a containing block for absolutely-positioned elements.  r?dholbert
Attachment #8696209 - Flags: review?(dholbert)
Bug 1230701 - Add test that position does not create a fixed-position containing block.  r?dholbert

I confirmed that the new test fails without the previous patch (since
the abspos element is 50px from the left edge of the viewport instead of
150px, and at the top edge instead of 100px from the top).  The test
passes with the patch.
Attachment #8696210 - Flags: review?(dholbert)
Attachment #8696209 - Flags: review?(dholbert) → review+
Comment on attachment 8696209 [details]
MozReview Request: Bug 1230701 - Make will-change:position create a containing block for absolutely-positioned elements.  r?dholbert

https://reviewboard.mozilla.org/r/27297/#review24695
Comment on attachment 8696210 [details]
MozReview Request: Bug 1230701 - Add test that position does not create a fixed-position containing block.  r?dholbert

https://reviewboard.mozilla.org/r/27299/#review24697
Attachment #8696210 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb137598c5821b8c28ffc0a8bc4ecac4420dfee9
Bug 1230701 - Make will-change:position create a containing block for absolutely-positioned elements.  r=dholbert

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5c7323533773bb131cc270ba4c53166ac87aa1c
Bug 1230701 - Add test that position does not create a fixed-position containing block.  r=dholbert
https://hg.mozilla.org/mozilla-central/rev/bb137598c582
https://hg.mozilla.org/mozilla-central/rev/a5c732353377
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
No longer blocks: 1231384
You need to log in before you can comment on or make changes to this bug.