gcontextmenu is null in folder-display/test-recent-menu.js

RESOLVED FIXED in Thunderbird 52.0

Status

Thunderbird
Testing Infrastructure
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 52.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

5.40 KB, patch
Magnus Melin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

3 years ago
Some new errors have cropped up when running folder-display/test-recent-menu.js. All I could notice so far when running that that interactively is that the context menu when invoked shows all items, not only those that are relevant in the context.

INFO -  TEST-START | /builds/slave/test/build/tests/mozmill/folder-display/test-recent-menu.js | setupModule
INFO -  TEST-PASS | /builds/slave/test/build/tests/mozmill/folder-display/test-recent-menu.js | test-recent-menu.js::setupModule
INFO -  TEST-START | /builds/slave/test/build/tests/mozmill/folder-display/test-recent-menu.js | test_move_message
INFO -  JavaScript error: chrome://messenger/content/nsContextMenu.js, line 424: TypeError: aNode is null
INFO -  JavaScript error: chrome://messenger/content/mailContextMenus.js, line 50: TypeError: gContextMenu is null
INFO -  JavaScript error: chrome://messenger/content/nsContextMenu.js, line 424: TypeError: aNode is null
INFO -  JavaScript error: chrome://messenger/content/mailContextMenus.js, line 50: TypeError: gContextMenu is null
INFO -  TEST-PASS | /builds/slave/test/build/tests/mozmill/folder-display/test-recent-menu.js | test-recent-menu.js::test_move_message
INFO -  TEST-START | /builds/slave/test/build/tests/mozmill/folder-display/test-recent-menu.js | test_delete_message
INFO -  JavaScript error: chrome://messenger/content/nsContextMenu.js, line 424: TypeError: aNode is null
INFO -  JavaScript error: chrome://messenger/content/mailContextMenus.js, line 50: TypeError: gContextMenu is null
INFO -  TEST-PASS | /builds/slave/test/build/tests/mozmill/folder-display/test-recent-menu.js | test-recent-menu.js::test_delete_message
INFO -  TEST-START | /builds/slave/test/build/tests/mozmill/folder-display/test-recent-menu.js | test_archive_message
INFO -  JavaScript error: chrome://messenger/content/nsContextMenu.js, line 424: TypeError: aNode is null
INFO -  JavaScript error: chrome://messenger/content/mailContextMenus.js, line 50: TypeError: gContextMenu is null
INFO -  TEST-PASS | /builds/slave/test/build/tests/mozmill/folder-display/test-recent-menu.js | test-recent-menu.js::test_archive_message
INFO -  TEST-START | /builds/slave/test/build/tests/mozmill/folder-display/test-recent-menu.js | teardownModule
INFO -  TEST-PASS | /builds/slave/test/build/tests/mozmill/folder-display/test-recent-menu.js | test-recent-menu.js::teardownModule
(Assignee)

Updated

2 years ago
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Component: General → Testing Infrastructure
OS: Unspecified → All
Hardware: Unspecified → All
(Assignee)

Comment 1

2 years ago
Created attachment 8801463 [details] [diff] [review]
patch

This works for me. The problem was that we just forced the context menu to open in click_menus_in_sequence. But it expects to be opened on a message so that it can determine which items to show. Without the patch it was opened at position 0,0 and contained all the items.

So the test was again calling an unsupported operation (the user can't open the menu anywhere, only on a message row in the message list).

Try run: 
https://hg.mozilla.org/try-comm-central/rev/d6a4e7068f5fd0ef67852a07b041c893c2f2efde
Attachment #8801463 - Flags: review?(mkmelin+mozilla)
(Assignee)

Updated

2 years ago
Depends on: 1310024

Comment 2

2 years ago
Comment on attachment 8801463 [details] [diff] [review]
patch

Review of attachment 8801463 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! r=mkmelin
Attachment #8801463 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 3

2 years ago
https://hg.mozilla.org/comm-central/rev/af218115880f13052e55f0fbe6c19b5b6853aa2a
Blocks: 1081763
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
(Assignee)

Updated

2 years ago
Blocks: 1310805
You need to log in before you can comment on or make changes to this bug.