1231268 - The "Pin" page will stay above primary layer and the rocket icon can't be removed.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Queena.Wen(Leave from Mozilla)]

Attachment: logcat_2354.txt

[1.Description]:
[Aries KK master][Flame KK master] the "Pin" page will stay above primary layer and the rocket icon can't be removed after user tap the pin site at the add picture view.
See attachments: Aries KK master.3GP&Aries KK master.png&logcat_2354.txt
Found time: 23:54

[2.Testing Steps]: 
1. Launch the Browser app
2. Tap on the url and type any url.(www.google.com)
3. Press "..."->"Pin".
4. Tap the home button after "Pin" page pops up
5. Launch the contacts app 
6. Tap the "+" icon and go to the Add contact page 
7. Tap the "+" icon to add a picture.


[3.Expected Result]: 
Step 7. The Select from view should appear.

[4.Actual Result]: 
Step 7-1. User can see the "Pin" page display above Select from view.
Step 7-2. If user taps the pin site, the rocket icon with naming contacts will appear on the homescreen, and the icon can't be removed unless user resets device. Same issue also occurs on Setting app when user choose to change the wallper.

[5.Reproduction build]: 
Device: Aries KK master(Affected)
Build ID               20151208222037
Gaia Revision          6b430ea7274af4c352de16b75e6bb85d7621ca83
Gaia Date              2015-12-08 06:31:07
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a8965ae93c5d098a4f91ad9da72150bb43df07a7
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151208.213715
Firmware Date          Tue Dec  8 21:37:23 UTC 2015
Bootloader             s1

Device: Flame KK master 512mb(Affected)
Build ID               20151208150206
Gaia Revision          6b430ea7274af4c352de16b75e6bb85d7621ca83
Gaia Date              2015-12-08 06:31:07
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a8965ae93c5d098a4f91ad9da72150bb43df07a7
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151208.183034
Firmware Date          Tue Dec  8 18:30:47 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK v2.5(Unaffected)
Build ID               20151208121136
Gaia Revision          2d54c29f429bed790b5d8284633812dc2b782518
Gaia Date              2015-12-02 14:41:15
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ff31a251b2f6149edf4fc0a199133ef2e190ceac
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151208.111803
Firmware Date          Tue Dec  8 11:18:12 UTC 2015
Bootloader             s1

Device: Flame KK v2.5 512mb(Unaffected)
Build ID               20151208120554
Gaia Revision          2d54c29f429bed790b5d8284633812dc2b782518
Gaia Date              2015-12-02 14:41:15
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ff31a251b2f6149edf4fc0a199133ef2e190ceac
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151208.111719
Firmware Date          Tue Dec  8 11:17:29 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free Test

Comment 1

[Queena.Wen(Leave from Mozilla)]

Attachment: Aries KK master.png

Comment 2

[Queena.Wen(Leave from Mozilla)]

Attachment: Aries KK master.3GP

Comment 3

[Norry.L.F(Leave from Mozilla)]

Hi Michael,

Good day. 
This bug is same with bug 1222334 from the actual result. Could you help to check? thanks. :)

Comment 4

[Norry.L.F(Leave from Mozilla)]

[Blocking Requested - why for this release]:

Regression bug, and serious user impact.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Bug 1222334 was uplifted to 2.5, and since 2.5 is unaffected by this bug it means there was a regression master in the meantime. Let's get a regression window.

Comment 6

[Max Murrell [MMurrell]]

This issue appears to be caused by changes from Bug 1223733

B2G Inbound Regression Window

Last Working
Environmental Variables:
Device: Flame 2.6
BuildID: 20151127081030
Gaia: 09c3d2f593799fa781b94006d3389e9cbb156c6e
Gecko: ba3bc0007148f8c2e196d2a6083f32afab8dff96
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D

First Broken
Environmental Variables:
Device: Flame 2.6
BuildID: 20151127091732
Gaia: 5b75fa8e7c71eca70be2c777a75e5814c88e1e14
Gecko: 3ec7c99d015079f8dc1c6466c0ef5826096790e8
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D

Last Working gaia / First Broken gecko - Issue does not occur
Gaia: 09c3d2f593799fa781b94006d3389e9cbb156c6e
Gecko: 3ec7c99d015079f8dc1c6466c0ef5826096790e8

First Broken gaia / Last Working gecko - Issue does occur
Gaia: 5b75fa8e7c71eca70be2c777a75e5814c88e1e14
Gecko: ba3bc0007148f8c2e196d2a6083f32afab8dff96

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/09c3d2f593799fa781b94006d3389e9cbb156c6e...5b75fa8e7c71eca70be2c777a75e5814c88e1e14

Comment 7

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Alberto the changes for bug 1223733 seem to have caused this issue.  Can you please take a look?

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1231268-pin-picture > mozilla-b2g:master

Comment 9

[Alberto Pastor [:albertopq]]

Comment on attachment 8697989 [details] [review]
[gaia] albertopq:1231268-pin-picture > mozilla-b2g:master

guillaume, could you please take a look? Thanks!

Comment 10

[Guillaume Marty [:gmarty]]

Comment on attachment 8697989 [details] [review]
[gaia] albertopq:1231268-pin-picture > mozilla-b2g:master

This looks good to me!

Comment 11

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/8f59f47be2c6151b9d303bfd4444370bd606653a

Comment 12

[Shally Li（leave from Mozilla）]

Hi Queena,

    Could you help to verify this bug?

Thank you very much.

Comment 13

[Queena.Wen(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Aries KK master and Flame KK master 512mb by the STR in comment 0 .

Actual result: The "Pin" page doesn't display above Select from view.
Reproduce rate: 0/10.

Device: Aries KK master(Pass)
Build ID               20151216003129
Gaia Revision          635c79fe14b5c4df919c20e7fc760c7a400ca7cc
Gaia Date              2015-12-15 17:39:35
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/e6463ae7eda2775bc84593bb4a0742940bb87379
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151216.001134
Firmware Date          Wed Dec 16 00:11:42 UTC 2015
Bootloader             s1

Device: Flame KK master 512mb(Pass)
Build ID               20151215150203
Gaia Revision          ee43a95f2bbe39c5ac8c9fcdec76749a56c02f2e
Gaia Date              2015-12-15 04:30:46
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cb66ffeb6725e8344818e8e2f707ae2eaeb953b4
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151215.184537
Firmware Date          Tue Dec 15 18:45:49 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0