1231274 - (RTL) Close button should should be in left

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Atique Ahmed Ziad [:atiqueahmedziad]]

Attachment: Screen Shot 2015-12-09 at 01.12.26.png

STR: 
1) Go to marketplace from mobile in rtl (https://marketplace-dev.allizom.org/?lang=ar)
2) Go to "more" from the footer menu

Actual: The close button overlapping the menu items. (see the attach pic)

Expected: It should be in left as the menu comes in right side.

Comment 1

[u557993]

Hi I want to work on fixing my first bug. Can I take this up?

Comment 2

[Atique Ahmed Ziad [:atiqueahmedziad]]

Sure! 

This is a part of Marketplace's Frontend- https://github.com/mozilla/fireplace

You need to make the change of code here. Read the README.md to setup marketplace's front-end locally in your pc.

Let me know if you need any help!

Comment 3

[David Durst [:ddurst]]

Atique -- do you want to be the mentor for this bug?

Comment 4

[Atique Ahmed Ziad [:atiqueahmedziad]]

sure!

Comment 5

[Davor Spasovski [:spasovski]]

Sorry folks it was super simple so I fixed it with the other RTL issues.

https://github.com/mozilla/fireplace/commit/dc317a4