1231306 - [e10s] Remote process doesn't immediately change Flash plugin state when I set it to "Always Activate"

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 45, 32bit, ID 20151206030448
STR:
1. Open "about:addons", set Shockwave Flash 19.0.0.245 to "Never Activate"
2. Restart the browser
3. Open https://www.mozilla.org/en-US/ in a new tab
4. Open "about:addons" (or switch to opened tab), set Flash to "Always Activate"
5. Open https://www.youtube.com/v/SzmLYHsAcZQ&start=83&end=127 (flash) in a new tab

Result:       
 There's a prompt window "What should Nighly do with this file?"

Expectations: 
 The flash player should load.

Workaround:
 To kill the remote process (or close all remote tabs), then open flash player in a new tab.
 Note that if dom.ipc.processCount is set to > 1, then you can only hope that when you kill a process,
 the new tab will be opened in a new process.

Comment 1

[Jim Mathies [:jimm]]

Sounds like an e10s blocker. Removing my ni so this falls into our triage list.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I can reproduce this.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

There were some bookkeeping issues here. The content process frequently sends up queries asking for the current list of plugins. Both the parent and child record an "epoch" value, which is an integer that changes whenever the list of plugins changes. The parent will not send down a new list of plugins if the child's epoch value is the same as the parent's--in this case, the two lists are already synchronized.

One problem here is that we weren't updating the epoch when changing the enabled state of a plugin. Another problem is that enabling a plugin should cause us to register it with the category manager so that it can be used as a "full page plugin" (typically only used for Acrobat or if you navigate directly to an .flv file). The child process was not doing the category manager registration.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67458bc680b2

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/67458bc680b2

Comment 7

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8701659 [details] [diff] [review]
patch

We'd like to land this for the beta 45 experiment. It's been in for a while and is low risk.

Approval Request Comment
[Feature/regressing bug #]: e10s
[User impact if declined]: fullscreen plugins may not work
[Describe test coverage new/current, TreeHerder]: on m-c
[Risks and why]: low
[String/UUID change made/needed]: none

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8701659 [details] [diff] [review]
patch

Taking it for the experiment

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/43e04381763f