1231375 - [experiment] Add a dialog to manage DNT settings

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

The new TP functionality in normal mode needs to be linked to the DNT header. We need to add a text string and link at the bottom of the TP section that allows users to “Manage DNT Settings” (copy not final). Clicking the “Manage DNT Settings” link launches a modal dialog that shows the value of the privacy.donottrackheader.enabled pref. This pref will be checked for previously opted-in DNT users, and becomes checked automatically and greyed out (disabled) when users use TP “Always”. When an expert user wants to manually change the DNT setting, she will be able to use this dialog to do so.

Comment 1

[:Paolo Amadini]

Attachment: MozReview Request: Bug 1231375 - Add a dialog to manage DNT settings.

Review commit: https://reviewboard.mozilla.org/r/29135/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29135/

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8702581 [details]
MozReview Request: Bug 1231375 - Add a dialog to manage DNT settings.

https://reviewboard.mozilla.org/r/29135/#review26369

My only concerns are about the strings, but otherwise this looks good.

::: browser/components/preferences/in-content/privacy.js:397
(Diff revision 1)
> +  {

Same style nit about putting the opening curly brace in the same line as the function keyword.

::: browser/locales/en-US/chrome/browser/preferences/donottrack.dtd:9
(Diff revision 1)
> +<!ENTITY doNotTrackCheckbox.label     "Use Do Not Track">

Are these checkbox label and dialog title strings final? They seem quite brief and different from the spec.

::: browser/locales/en-US/chrome/browser/preferences/privacy.dtd:19
(Diff revision 1)
> +<!ENTITY  doNotTrack.settings.label     "Do Not Track settings">

The text in links always includes the verb in our preferences as far as I can see. Also, the strings are not the ones I see in the spec. Did we decide do use these simpler ones?

Comment 3

[:Paolo Amadini]

(In reply to Panos Astithas [:past] from comment #2)
> Are these checkbox label and dialog title strings final? They seem quite
> brief and different from the spec.
> 
> The text in links always includes the verb in our preferences as far as I
> can see. Also, the strings are not the ones I see in the spec. Did we decide
> do use these simpler ones?

No, none of the strings are final and I suggested to land this bug only after a copy review. Good point about including the verb in the link.

Comment 4

[:Paolo Amadini]

Attachment: Screenshot of Privacy Preferences

This is how the change to the Privacy Preferences looks like, without the new Tracking Protection preferences.

Comment 5

[:Paolo Amadini]

Attachment: Screenshot of the Do Not Track dialog

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6fe85dbddb0c

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6fe85dbddb0c

Comment 8

[Paul Silaghi, QA [:pauly]]

(In reply to Panos Astithas [:past] from comment #0)
> becomes checked automatically
> and greyed out (disabled) when users use TP “Always”
This is not happening.

Moreover, is there a way to actually test the DNT functionality, on a specific site or something? I don't know what should happen after checking the DNT option.

Comment 9

[:Paolo Amadini]

(In reply to Paul Silaghi, QA [:pauly] from comment #8)
> (In reply to Panos Astithas [:past] from comment #0)
> > becomes checked automatically
> > and greyed out (disabled) when users use TP “Always”
> This is not happening.

This description still refers to the old mockup linked in this bug's URL field, while what we implemented is shown in the screenshots, so nothing to worry about here.

> Moreover, is there a way to actually test the DNT functionality, on a
> specific site or something? I don't know what should happen after checking
> the DNT option.

You can use the Network panel from the Developer Toolbox to check whether the DNT header is sent or not.

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

There is also this page that tests for DNT on the server:
https://www.mozilla.org/en-US/firefox/dnt/

Comment 11

[Alfred Kayser]

Having a separate dialog for just a checkbox and link seems a bit too much ...
Or is there more coming in this area of DNT?

Comment 12

[Paul Silaghi, QA [:pauly]]

(In reply to Panos Astithas [:past] from comment #10)
> There is also this page that tests for DNT on the server:
> https://www.mozilla.org/en-US/firefox/dnt/
I see a few google-analitycs.com requests are not sent, when DNT=ON.
Note that the requests are also not sent if DNT=OFF and TP="always".
Please confirm this is expected.

Comment 13

[Panos Astithas (he/him) [:past] (please ni?)]

Yes, this works as expected. mozilla.org respects DNT in the first case and Firefox blocks the resource loads in the second case.

Comment 14

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Alfred Kayser from comment #11)
> Having a separate dialog for just a checkbox and link seems a bit too much
> ...
> Or is there more coming in this area of DNT?

The dialog does look a bit spartan, but although we might iterate on it in the future, the main reason to move the option there was to avoid the user-reported confusion between TP and DNT. Tracking Protection is the main way we expect users to declare an intent to not be tracked, and Firefox will handle the DNT signal according to that intent. Most users shouldn't have to care about setting DNT, but advanced users who have particular preferences can still do so.

Comment 15

[Paul Silaghi, QA [:pauly]]

Verified fixed based on comment 13 on FF 46.0a1 (2016-01-13) Win 7, Ubuntu 14.04, OS X 10.9.5.