1231414 - RTCPeerConnection.addTrack should not require a stream to be passed

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Per https://github.com/w3c/webrtc-pc/issues/288 calling addTrack with no streams should be OK.

Comment 1

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 3

[Byron Campen [:bwc]]

This is turning into a major headache with web-platform-tests, requiring lots of tests (that aren't really testing addTrack) to be disabled.

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1231414 - Part 1: Allow addTrack without a stream argument. r?jib,smaug

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1231414 - Part 2: Mark some wpt as expected to succeed. r?jib

Depends on D19841

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11852b4fb06b239b78039a438d7f83c280bb6679

Comment 7

[Byron Campen [:bwc]]

Review ping.

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

All reviews here look accepted.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/918f7a08c59b
Part 1: Allow addTrack without a stream argument. r=jib,smaug
https://hg.mozilla.org/integration/autoland/rev/6be475d0d9b8
Part 2: Mark some wpt as expected to succeed. r=jib

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/918f7a08c59b
https://hg.mozilla.org/mozilla-central/rev/6be475d0d9b8

Comment 11

[Eric Shepherd [:sheppy]]

Documentation updated:

I've made substantial revisions to the article on addTrack() to cover this and to explain in more detail the relationship between the tracks and streams across a peer connection. This would definitely benefit from a review:

https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/addTrack

I've also made affiliated revisions to the following articles. Some are error corrections, some are clarifications, and there are a few additions of missing details:

https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/addStream
https://developer.mozilla.org/en-US/docs/Web/API/MediaStream/MediaStream
https://developer.mozilla.org/en-US/docs/Web/API/RTCTrackEvent

Since this is a bug fix, I don't think it warrants a BCD update. If there's disagreement, it could be added as a note -- I'm not sure adding a "feature" row for this makes sense given that it's a bug fix.

Added to Firefox 67 for developers.