Closed Bug 1231548 Opened 9 years ago Closed 9 years ago

[TV][2.5] Layout to sign-in dialog of Firefox account is broken.

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: rexboy, Unassigned)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker])

User Story

As a user, I want to be prompted if Content wants to access privileged APIs on the FxOS (much like it’s done in the browser today)

Attachments

(1 file)

[gaia] rexboy7:1231548-fxa-sign-css-fix > mozilla-b2g:master
46 bytes, text/x-github-pull-request
lchang
: review+
danhuang
: feedback+
jocheng
: approval-gaia-v2.5+
Details | Review
+++ This bug was initially created as a clone of Bug #1217765 +++ This is a regression caused by 1217765. See the comment 25 of bug 1217765 for the bug description: Dan wrote: > Hi Rex, the firefox account sign-in page would also use the css rule: > '[role="dialog"].generic-dialog'. > So the change in tv_apps/smart-system/style/themes/default/core.css > affect the style of firefox account sign-in page. > If the change in core.css is for general purpose, I think it's better > to update the 'fxa-dialog' css rule for customizing firefox account > dialog to fix the issue.
No longer depends on: 1217765
Depends on: 1217765
Comment on attachment 8697133 [details] [review] [gaia] rexboy7:1231548-fxa-sign-css-fix > mozilla-b2g:master So this is a one-line css fix. Luke may you help review this patch? And Dan you may want to check if it fixes your problem. Thanks!
Attachment #8697133 - Flags: review?(lchang)
Attachment #8697133 - Flags: feedback?(dhuang)
Comment on attachment 8697133 [details] [review] [gaia] rexboy7:1231548-fxa-sign-css-fix > mozilla-b2g:master Looks good!
Attachment #8697133 - Flags: review?(lchang) → review+
Comment on attachment 8697133 [details] [review] [gaia] rexboy7:1231548-fxa-sign-css-fix > mozilla-b2g:master Thanks for the effort. The firefox account sign-in page looks good. Thanks.
Attachment #8697133 - Flags: feedback?(dhuang) → feedback+
QA Whiteboard: [COM=TV Browser]
status-b2g-v2.5: --- → affected
status-b2g-master: --- → affected
master https://github.com/mozilla-b2g/gaia/commit/ee43a95f2bbe39c5ac8c9fcdec76749a56c02f2e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8697133 [details] [review] [gaia] rexboy7:1231548-fxa-sign-css-fix > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): regression of 1217765 [User impact] if declined: fx account login screen suffers bad layout [Testing completed]: local test done [Risk to taking this patch] (and alternatives if risky): small, just CSS change [String changes made]: none
Attachment #8697133 - Flags: approval-gaia-v2.5?
blocking-b2g: --- → 2.5+
Whiteboard: [ft:conndevices][partner-blocker] → [ft:conndevices][partner-cherry-pick][partner-blocker]
Comment on attachment 8697133 [details] [review] [gaia] rexboy7:1231548-fxa-sign-css-fix > mozilla-b2g:master Approve for TV 2.5
Attachment #8697133 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: