Closed
Bug 1231548
Opened 9 years ago
Closed 9 years ago
[TV][2.5] Layout to sign-in dialog of Firefox account is broken.
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect, P2)
Tracking
(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)
VERIFIED
FIXED
| blocking-b2g | 2.5+ |
People
(Reporter: rexboy, Unassigned)
References
Details
(Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker])
User Story
As a user, I want to be prompted if Content wants to access privileged APIs on the FxOS (much like it’s done in the browser today)
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
lchang
:
review+
danhuang
:
feedback+
jocheng
:
approval-gaia-v2.5+
|
Details | Review |
+++ This bug was initially created as a clone of Bug #1217765 +++ This is a regression caused by 1217765. See the comment 25 of bug 1217765 for the bug description: Dan wrote: > Hi Rex, the firefox account sign-in page would also use the css rule: > '[role="dialog"].generic-dialog'. > So the change in tv_apps/smart-system/style/themes/default/core.css > affect the style of firefox account sign-in page. > If the change in core.css is for general purpose, I think it's better > to update the 'fxa-dialog' css rule for customizing firefox account > dialog to fix the issue.
|
||
Comment 1•9 years ago
|
||
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8697133 [details] [review] [gaia] rexboy7:1231548-fxa-sign-css-fix > mozilla-b2g:master So this is a one-line css fix. Luke may you help review this patch? And Dan you may want to check if it fixes your problem. Thanks!
Attachment #8697133 -
Flags: review?(lchang)
Attachment #8697133 -
Flags: feedback?(dhuang)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8697133 [details] [review] [gaia] rexboy7:1231548-fxa-sign-css-fix > mozilla-b2g:master Looks good!
Attachment #8697133 -
Flags: review?(lchang) → review+
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8697133 [details] [review] [gaia] rexboy7:1231548-fxa-sign-css-fix > mozilla-b2g:master Thanks for the effort. The firefox account sign-in page looks good. Thanks.
Attachment #8697133 -
Flags: feedback?(dhuang) → feedback+
|
||
Updated•9 years ago
|
|
|
Reporter | |
Comment 5•9 years ago
|
||
master https://github.com/mozilla-b2g/gaia/commit/ee43a95f2bbe39c5ac8c9fcdec76749a56c02f2e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 6•9 years ago
|
||
Comment on attachment 8697133 [details] [review] [gaia] rexboy7:1231548-fxa-sign-css-fix > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): regression of 1217765 [User impact] if declined: fx account login screen suffers bad layout [Testing completed]: local test done [Risk to taking this patch] (and alternatives if risky): small, just CSS change [String changes made]: none
Attachment #8697133 -
Flags: approval-gaia-v2.5?
|
||
Updated•9 years ago
|
blocking-b2g: --- → 2.5+
Whiteboard: [ft:conndevices][partner-blocker] → [ft:conndevices][partner-cherry-pick][partner-blocker]
|
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8697133 [details] [review] [gaia] rexboy7:1231548-fxa-sign-css-fix > mozilla-b2g:master Approve for TV 2.5
Attachment #8697133 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
|
||
Comment 8•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/109f98c4383306f02e4d354c719d62bda3df9ccc for 2.5
|
|
||
Updated•9 years ago
|
This issue is verified on v2.5 and v2.6 latest build. The layout to sign-in dialog of Firefox account shows without error. [Build Info] 2.6 TV Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/5b90c09648798d8d66c4b08f81402b27acf0dc08 gecko: https://hg.mozilla.org/mozilla-central/rev/05c087337043dd8e71cc27bdb5b9d55fd00aaa26 2.5 TV Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/81460a1025c357ca8a52e5bc8647fff6bb005638 gecko: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/240426e9718eab5661517e3f9ad6173819284615 mulet: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•