1231763 - Extract breakdown parsing from JS::ubi::Census

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Extract breakdown parsing from JS::ubi::Census

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6899cc4b73d5

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Extract breakdown parsing from JS::ubi::Census

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Fixes for gecko.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=310018edcc21

Comment 5

[Jim Blandy :jimb]

Comment on attachment 8697471 [details] [diff] [review]
Extract breakdown parsing from JS::ubi::Census

Review of attachment 8697471 [details] [diff] [review]:
-----------------------------------------------------------------

Now that I've looked this over, it seems like a move in the right direction. The different operations (parse, traverse) take arguments that are reasonable for their role, and the dependency on Census is gone, as required. Thanks very much!

Just one hunk needs to come out, I think:

::: js/public/Utility.h
@@ +306,5 @@
> +    template <class T, typename... Args>                        \
> +    QUALIFIERS T *                                              \
> +    NEWNAME(Args&&... args) MOZ_HEAP_ALLOCATOR {                \
> +        void* memory = ALLOCATOR(sizeof(T));                    \
> +        return MOZ_LIKELY(memory)                               \

I don't think this change is controversial, but I think it should be put in a separate bug simply because it's so central. Terrence might have something to add, for example.

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Extract breakdown parsing from JS::ubi::Census

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Split the MOZ_LIKELY in js_new out to bug 1233101.

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Extract breakdown parsing from JS::ubi::Census

Fix the static analysis bustage by adding explicit constructors where needed.

Comment 9

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=86210fb43849

Comment 10

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Pretty sure those hazard failures are infra as I'm seeing them in other unrelated pushes as well.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a87d841e91aa

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a87d841e91aa