1231929 - Add telemetry to Firefox Sync

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P2)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1231929.sync.telemetry > mozilla-b2g:master

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

The attached patch adds telemetry to record user actions related to Sync: enable, disable and manual sync. For further information (i.e. new users) we can use Syncto metrics.

Tamara, do we have telemetry enabled for the TV?

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8708296 [details] [review]
[gaia] ferjm:bug1231929.sync.telemetry > mozilla-b2g:master

YiFan, could you take a look at the TV parts, please? Thanks!

Comment 4

[Tamara Hills [:thills]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #2)

> Tamara, do we have telemetry enabled for the TV?

Hi Fernando,

I'm going to expose my ignorance of how tv gets built here...  I'm looking at gaia/tv_apps and from what I can gather, it does not look like telemetry is enabled here.  Essentially, a setting called metrics.selectedMetrics.level needs to be set in order for telemetry to be turned on.  In phones, it can get turned on via the build config (e.g. for a foxfooder) or the user can be given a choice to turn it on/off both in the FTU and the settings.  It looks like that has not been done.   

I would think we would need some conversations with the product owners before either pushing it into the FTU or the settings.

Let me know if I can be of further help on this.  

-tamara

Comment 5

[yifan [:yifan][:yliao]]

Hi Joe,

The intent of this patch is to record user sync action. We only record app usage on tv now, can we add user sync action in telemetry? Could you please help to confirm if there is any legal issue?

Comment 6

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8708296 [details] [review]
[gaia] ferjm:bug1231929.sync.telemetry > mozilla-b2g:master

Left one comment on github.

Comment 7

[yifan [:yifan][:yliao]]

Comment on attachment 8708296 [details] [review]
[gaia] ferjm:bug1231929.sync.telemetry > mozilla-b2g:master

Thank you Fernando and Tamara. No the advanced telemetry is not handled in TV system. According to Luke once phone and TV systems merged (if there's no direction change...) it will be enabled and the feature will be evaluated on TV.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Thank you folks. I'll land only the phone part then.

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/7f6680d4269fef26acfb9ff68c59a0b5232a3685