1231963 - ESLint should treat global `this` as the global scope

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Kris Maglione [:kmag]]

ESLint doesn't treat `this` at the top level as a reference to the global scope. This causes problems for many JSMs, which have to define globals as properties of `this` for the sake of the b2g loader.

I'm not sure if this should be fixed in ESLint or implemented as a plugin, but either way, it affects a lot of our code.

Comment 1

[Tom Tromey :tromey]

This also affects some code in devtools.

Comment 2

[Tom Tromey :tromey]

Attachment: handle top-level "this.mumble" assignments in eslint

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8709534 [details] [diff] [review]
handle top-level "this.mumble" assignments in eslint

Review of attachment 8709534 [details] [diff] [review]:
-----------------------------------------------------------------

Couldn't be simpler, r+.

Comment 4

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c445645ef9f7

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cf165d1764d6

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cf165d1764d6

Comment 7

[Patrick Brosset <:pbro>]

Nice one Tom!
I think this (and other rules like import-globals-from, etc.) should be mentioned to a wider audience in an email to dev-platform. Many teams are in the process of getting rid of eslint errors, and these rules come in very handy. Would you like to do that?

Comment 8

[Tom Tromey :tromey]

Actually this rule got unified with some others in bug 1245916,
and enabled by default.  Also from grepping a bit it seems the other
groups are already using some of the other mozilla rules.
So, I think maybe an email isn't needed.