1232125 - Text selection highlight is not shown

Status: NEW

(Core :: Layout: Text and Fonts, defect)

Description

[Alice0775 White]

Attachment: testcase.zip

Steps to reproduce:
1. type text in textbox
2. Attempt to select the text

Actual results:
Text selection highlight is not shown

Expected results:
Text selection highlight is be shown

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ae1034cd5067&tochange=5a79877003e8

Regressed by:
5a79877003e8	Masayuki Nakano — Bug 556694 Selection color isn't reverted when input field is specified only background-color r=dbaron

Comment 2

[j.j.]

Attachment: testcase without <input>

This bug doesn't need an <input>

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I cannot reproduce it. Don't you mean bug 292191?

Comment 4

[Alice0775 White]

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #3)
> I cannot reproduce it.


I can reproduce Nightly45.0a1 on Windows7 classic. No background highlight, no text color changing.

No background highlight on windows10 and ubuntu14.04. It is difficult to distinguish between normal and selected text.

> Don't you mean bug 292191?

Bug 292191 should be different issue.
Because, this bug is regressed since Firefox4.0 (2010).

Comment 5

[j.j.]

Mozilla/5.0 (Windows NT 5.1; rv:42.0) Gecko/20100101 Firefox/42.0

On XP selected text color changes more or less visible, depending on OS theme color setting.
Selection background color is white.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Could you attach a screenshot and comment the selection color settings of Windows? Check the registry values of Hilight and HilightText under HKEY_CURRENT_USER\Control Panel\Colors.

Comment 7

[Alice0775 White]

Attachment: screenshot

Screenshot, selected 'def'

https://hg.mozilla.org/mozilla-central/rev/06ab805e14b5e6d8a8a99c7846c8fde163a9e5d7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 ID:20151214122242


[HKEY_CURRENT_USER\Control Panel\Colors]

"Hilight"="10 36 106"
"HilightText"="255 255 255"

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: zoomed screenshot

Looks like actually selected but just it's hard to distinguish.

I still believe that this is a dup of bug 292191. According to your testcases, the selection has enough contrast with its background-color but the background-color is really different from background-image. Bug 556694 just fixes the reverting selection colors to work with themed <input> element.

Comment 9

[Astley Chen (inactive)]

looks like the symptom is not existing on testing url nor attached test cases.
Do we consider to set this bug as dup of bug 292191 for further enhancement ?

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yes, I think so.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Andrei, can anyone on your team reproduce this?

Comment 12

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to reproduce this issue, using the attached test case from Comment 0 and the test case attached to Comment 2, on all the latest Firefox builds.
The tests were performed on Firefox 51.0a1(2016-08-24), Firefox 50.0a2(2016-08-24), Firefox 49.0b6 and on Firefox 48.0.2, under Windows 10x64, Windows XP x64 SP2, Ubuntu 14.04x86.

On Mac OS X 10.11.1 the issue is not reproducible.
Also, I was not able to reproduce this issue using the website from the attachment from Comment 7.

Note that on Windows XP, the issue appears to have the higher impact.
I am attaching a screenshot with the results: https://i.imgur.com/IqOIPlE.png

Please let me know if I can help any further with the investigation.

Comment 13

[Gerry Chang [:gchang]]

Per comment #9, mark 51 fix-optional, but we can still take this in 51 early beta.

Comment 14

[Jonathan Watt [:jwatt]]

Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)