The default bug view has changed. See this FAQ.

If using background-image in an element, we should reverse the result of reverse selection algorithm when the element's foreground color and background color is similar

ASSIGNED
Assigned to

Status

()

Core
Selection
P3
enhancement
ASSIGNED
12 years ago
7 months ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 obsolete attachments)

(Assignee)

Description

12 years ago
If an page is using background in an element, the reverse selection system is
faild when the background color is not similar to background image.
If the element's foreground color and background color is similar and existing
background image, we should reverse the current reverse selection result.
(Assignee)

Updated

12 years ago
Priority: -- → P3
Target Milestone: --- → mozilla1.9alpha
(Assignee)

Updated

12 years ago
Summary: If using background-image in an element, we should reverse the result of reverse selection algorithm when the element's foreground color and backcolor is similar → If using background-image in an element, we should reverse the result of reverse selection algorithm when the element's foreground color and background color is similar

Comment 1

12 years ago
Perhaps, but I wonder if exposing (if not already exposed, forgive me for not
knowing image related api) a method such as HasTransparant in the Image would be
worth it, and if there are transparant bits for the image, we could then assume
that the author does intend the specified background color to be 'correct'. [and
as such may be worth exchanging selection colors as currently designed]
(Assignee)

Comment 2

12 years ago
Justin:
If webpage author using transparent image, I think that the foreground color and
background color are _not_ similar.
So, I want to change the behavior when the colors are similar.

Comment 3

12 years ago
Good enough for me, but just for thought, in some of my personal designs I have
done slight gradients (transparant/alpha-scale) where the actual specified
background color is very close to what the image shows, though I can easily
conceive that I am a minority in that use.
(Assignee)

Comment 4

12 years ago
*** Bug 292660 has been marked as a duplicate of this bug. ***
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 5

12 years ago
additional testcases:
https://infosec.navy.mil/
http://mozilla.minutedesign.com/
(Assignee)

Comment 6

12 years ago
Created attachment 192919 [details] [diff] [review]
Patch rv1.0
Attachment #192919 - Flags: superreview?(bzbarsky)
Attachment #192919 - Flags: review?(bzbarsky)
(Assignee)

Comment 7

12 years ago
Created attachment 192920 [details] [diff] [review]
Patch rv1.0 -u8pw
(Assignee)

Comment 8

12 years ago
*** Bug 294485 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 9

12 years ago
My patch doesn't work fine on http://www.uoguelph.ca/~stuartr/
This is very difficult problem. The page can look the text if we don't load
images. So, the page's text color and background color conbination has
sufficient contrast. On this case, we cannot fix with my approach.
(Assignee)

Comment 10

12 years ago
I have an idea. But I don't like this way.

If the page uses background image and it's spcified by other element(not equal
background color specified element), we use text color for selection background
color. If so, the text color and actual background color combination may have
sufficient contrast. But I think that the looks is not good.
# If background image and color specified same element, we trust the background
color.
I won't be able to review this any time in the near future (at least 2+ weeks).
 I'd really appreciate it if you could find another reviewer...
(Assignee)

Comment 12

12 years ago
Umm... I wrote test patch by comment 10. But it is not better than previous
patch. Please ignore comment 10.
(Assignee)

Comment 13

12 years ago
Comment on attachment 192919 [details] [diff] [review]
Patch rv1.0

I cancel the review. Because I try to fix bug 170951 and bug 113161 before
this.
Attachment #192919 - Flags: superreview?(bzbarsky)
Attachment #192919 - Flags: review?(bzbarsky)
(Assignee)

Updated

12 years ago
Depends on: 113161, 170951
(Assignee)

Updated

11 years ago
No longer depends on: 56314
(Assignee)

Updated

11 years ago
No longer depends on: 113161
(Assignee)

Updated

11 years ago
Blocks: 56314
(Assignee)

Comment 14

11 years ago
*** Bug 345210 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 15

11 years ago
*** Bug 332612 has been marked as a duplicate of this bug. ***

Comment 16

10 years ago
http://www.ed.ac.uk/studying/

is another example (text in the white column on the right will select with a white background due to the blue bg colour of the page itself).

Masayuki, now that the two bugs you mentioned in comment #13 are fixed, is there any chance you'll try to fix this one next? :-)
(Assignee)

Updated

9 years ago
Target Milestone: mozilla1.9alpha1 → ---
(Assignee)

Updated

9 years ago
Attachment #192920 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Attachment #192919 - Attachment is obsolete: true

Comment 17

9 years ago
(In reply to comment #16)
> http://www.ed.ac.uk/studying/
> 
> is another example (text in the white column on the right will select with a
> white background due to the blue bg colour of the page itself).

I'm not seeing a white column on the right here. Did the page change?
QA Contact: selection
You need to log in before you can comment on or make changes to this bug.