123216 - no caret in password dialogs

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Brian Ryner (not reading)]

On current trunk builds on Linux:

Bring up a dialog with a text field, for example, an ftp password dialog:
ftp://[e-mail]/

Note that there is no caret shown in the dialog, but you can type.

This is a regression that appeared after the patch for bug 114580 was checked in.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

This is kind of a silly patch, but it does fix the problem.  There's weirdness
with initial window focus on Linux that we really need to figure out at some
point.

Comment 2

[Joe Hewitt (gone)]

Comment on attachment 67644 [details] [diff] [review]
patch

setTimeout, my dear friend. So we meet again.

Comment 3

[Håkan Waara]

Comment on attachment 67644 [details] [diff] [review]
patch

Kinda hacky. :-(

Please log a new bug on this new focus weirdness (to track the real fix).

r=hwaara

Comment 4

[Blake Ross]

Nit: it's a bit faster to just pass in the function name directly so the js
engine doesn't have to parse and compile "function()", e.g.

  setTimeout(focus, 0);
  setTimeout(GetAttention, 0);

or so brendan tells me, anyway.

Comment 5

[[e-mail]]

Attachment: Use setTimeout( function, ... ) not setTimeout( string, ... )

Like this, Blake?

Comment 6

[Blake Ross]

Yeah.

Comment 7

[Joe Hewitt (gone)]

As jag has just pointed out, dialog.xml already handles the task of setting the
initial focus (via the onload handler), so we should just remove the focus()
call from commonDialog

Comment 8

[Joe Hewitt (gone)]

Attachment: patch

Comment 9

[Joe Hewitt (gone)]

Comment on attachment 67834 [details] [diff] [review]
patch

patch is by jag, so sr=hewitt. bryner has supposedly tested this and it works.

Comment 10

[Brian Ryner (not reading)]

yeah, r=me

Comment 11

[Joe Hewitt (gone)]

fixed

Comment 12

[Terri Preston]

Verified fixed linux build 2002021412