1232216 - test_timezone_definition.js only tests every second timezone/alias

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Geoff Lankow (:darktrojan)]

From the test:

> while (aliases.hasMore()) {
>     foundAlias = true;
>     resolveAlias(aliases.getNext());
>     aliases.getNext();
> }

There's two calls to getNext, which not only skips half of the aliases, it breaks if there is an odd number of them. I've removed this second call from the loop in zone_test with https://hg.mozilla.org/comm-central/rev/5f239d0dd5b6 to fix bustage, but doing so in alias_test exposes a failure:

> JavaScript Error: "Couldn't find America/Indianapolis"

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1232216-1.diff

That turned out to be easier to debug than I expected.

Comment 2

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/comm-central/rev/ee52f20e5aca