test_timezone_definition.js only tests every second timezone/alias

RESOLVED FIXED in 4.7

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: darktrojan, Assigned: darktrojan)

Tracking

unspecified

Details

Attachments

(1 attachment)

Assignee

Description

4 years ago
From the test:

> while (aliases.hasMore()) {
>     foundAlias = true;
>     resolveAlias(aliases.getNext());
>     aliases.getNext();
> }

There's two calls to getNext, which not only skips half of the aliases, it breaks if there is an odd number of them. I've removed this second call from the loop in zone_test with https://hg.mozilla.org/comm-central/rev/5f239d0dd5b6 to fix bustage, but doing so in alias_test exposes a failure:

> JavaScript Error: "Couldn't find America/Indianapolis"
Assignee

Comment 1

4 years ago
That turned out to be easier to debug than I expected.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #8697899 - Flags: review?(philipp)
Attachment #8697899 - Flags: review?(philipp) → review+
Assignee

Comment 2

4 years ago
https://hg.mozilla.org/comm-central/rev/ee52f20e5aca
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.7
Assignee

Updated

4 years ago
See Also: → 1212076
You need to log in before you can comment on or make changes to this bug.