1232290 - Package codemirror with the same layout than in source tree.

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect)

Description

[Alexandre Poirot [:ochameau]]

Similar to bug 1219723, we need to avoid build time magic in order to offer hot reload.
Some magic has recently been introduced in codemirror with some mapping being done differently at build time.
We should keep same layout between in-source and runtime so that we can easily map resource:// and chrome URI to another devtools root folder and have hot reload.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Package codemirror with the same layout than in source tree.

Comment 2

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=55501bc41f2d

Comment 3

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b58573a8056c

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Package codemirror with the same layout than in source tree.

Comment 5

[James Long (:jlongster)]

Comment on attachment 8699022 [details] [diff] [review]
Package codemirror with the same layout than in source tree.

Review of attachment 8699022 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, I noticed this as well! Assuming this doesn't break anything, looks great.

Comment 6

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/0dd30d9b7c9a86a0033c9529f2b540e9ffcba7ee
Bug 1232290 - Package codemirror with the same layout than in source tree. r=jlongster

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0dd30d9b7c9a

Comment 8

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	        beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected